Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V6] Add ERC20 incentive type, improve multiplier #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[V6] Add ERC20 incentive type, improve multiplier #42

wants to merge 2 commits into from

Conversation

brkagithub
Copy link
Collaborator

No description provided.

u-hubar
u-hubar requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@u-hubar u-hubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor adjustments needed. Also don't forget to bump the package version in the config

dkg/paranet.py
@@ -259,8 +265,13 @@ def is_voter(
self,
ual: UAL,
address: Address | None = None,
incentives_type: ParanetIncentivizationType = ParanetIncentivizationType.NEUROWEB,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, we shouldn't do that imo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I c your logic, but I would rather make default None and if it's None, then figure it out from the ual

dkg/paranet.py Outdated
) -> str | dict[str, str]:
incentives_pool_name = f"Paranet{str(incentives_type)}IncentivesPool"
incentives_pool_name = f"ParanetNeurowebIncentivesPool"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to constants perhaps

dkg/dataclasses.py Outdated
NEUROWEB = auto()
class ParanetIncentivizationType(Enum):
NEUROWEB = "Neuroweb"
ERC20 = "NeurowebERC20"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call it NEUROWEB_ERC20? There is no support for any custom ERC20 atm, so perhaps it would be more clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u-hubar u-hubar u-hubar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brkagithub @u-hubar