Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ompt_frame_t is replaced with omp_frame_t in latest llvm-openmp library #86

Open
zygyz opened this issue Aug 7, 2018 · 5 comments
Open

Comments

@zygyz
Copy link

zygyz commented Aug 7, 2018

Compilation error is generated in ompt-tsan.cpp. 'ompt_frame_t' is no longer used and is replaced with omp_frame_t.

@zygyz
Copy link
Author

zygyz commented Aug 7, 2018

ompt_wait_id_t --> omp_wait_id_t as well.

@jprotze
Copy link
Contributor

jprotze commented Aug 7, 2018

If there are issues, currently please use the release_60 tag of the OpenMP runtime, or just the release 6.0 binaries.
Once release_70 will be out, we will update to that interface.

I hope, with LLVM 8.0 release the OMPT interface will be stable and we also try to deliver the archer runtime with LLVM 8.0.

@SteffenSeckler
Copy link

any update on this? even https://reviews.llvm.org/D45890 still doesn't look to be updated accordingly

@SteffenSeckler
Copy link

or is the solution to use https://github.com/PRUNERS/openmp/tree/archer_80_reduction ?

@jprotze
Copy link
Contributor

jprotze commented Jul 16, 2019

The final OpenMP 5.0 specification says ompt_frame_t and ompt_wait_id_t. Not that we would really use the frame_t in Archer. This is also the typedef delivered with llvm/8.0.

Both https://reviews.llvm.org/D45890 and https://github.com/PRUNERS/openmp/tree/archer_80_reduction are right.
The latter branch also contains an implementation of the reduction event, we did not push to upstream yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants