Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and "fix" (transcode) VBR mp3s #1109

Open
3 tasks
cavis opened this issue Sep 30, 2024 · 0 comments
Open
3 tasks

Detect and "fix" (transcode) VBR mp3s #1109

cavis opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
Level: Intermediate Smooth for some, bumpy for others Priority: Normal Cruising speed Size: M Consumes a day or two

Comments

@cavis
Copy link
Member

cavis commented Sep 30, 2024

Our waveform editor has some issues with VBR mp3s. Which makes marking ad-breaks tricky.

When a user uploads a VBR MP3, we should transcode it to CBR.

  • Make Porter return some indication that the file was VBR - easiest just to check the mpck output
  • Feeder should check that flag and fire a fix media task
  • The fix-media-task would also have to re-encode that file to CBR for these cases (slightly different command).

I think it makes sense to build this into the existing "fix media" jobs? And to do this for both Uncut and multi-segment Contents? But I could be convinced otherwise.

@cavis cavis added Level: Intermediate Smooth for some, bumpy for others Priority: Normal Cruising speed Size: M Consumes a day or two labels Sep 30, 2024
@cavis cavis self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Intermediate Smooth for some, bumpy for others Priority: Normal Cruising speed Size: M Consumes a day or two
Projects
None yet
Development

No branches or pull requests

1 participant