Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

augment these labels #116

Open
MattHJensen opened this issue Apr 14, 2020 · 2 comments
Open

augment these labels #116

MattHJensen opened this issue Apr 14, 2020 · 2 comments
Assignees
@MattHJensen

Comments

@MattHJensen
Copy link
Contributor

image
@MattHJensen MattHJensen self-assigned this Apr 14, 2020
@jdebacker
Copy link
Member

@MattHJensen These come from the policy_current_law.json in Tax-Calculator, I believe. It's not clear how to change these label names since these are choices in the ParamTools schema for Tax-Calculator.

If you or @hdoupe can confirm this, I'll move this issue over to the Tax-Calculator repo.

@MattHJensen
Copy link
Contributor Author

@jdebacker I am ok with that, but it will cause a breaking change in Tax-Calculator so we'll have to manage when a fix gets merged into master. (We could either leave a PR open or perhaps start a 4.0.0 branch.)

When this was discussed in the past (in a Tax-Calculator issue or the PR where these labels were introduced, I believe, that I can't find right now), Martin suggested adding a step in Tax-Brain that augments the Tax-Calculator labels to whatever Tax-Brain wants them to be. This approach makes a lot of sense with me, but I am ok doing it either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattHJensen MattHJensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattHJensen @jdebacker