-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Odometry Instructions Are not Clear #1376
Comments
@TSC21 Can you comment on this? To me it looks wrong where we talk about setting the offsets in EKF
Specifically, isn't it just the vision sensor offset that you're interested in - whether it's a MOCAP or other system, this setting is just to map your sensors to the center of gravity. If I'm correct, we'd remove "or MoCap markers" from this string. |
@hamishwillee, @TSC21, I don't want to mix various topics here, but the other relevant problem that I see, is in the way that mavros transforms odometry data from a vision system body frame to drone center. Specifically, if there is a translation between vision system body frame (for example camera in a visual odometry system) and drone center (base_link), from rigid body dynamics we know (please see section 5.1.3 in this link) that linear velocity of base_link will depend on the transformation between the camera and base_link and angular velocity of the camera frame. Looking at this line in mavros source code, I am not clear how this calculation could be possibly accurate without any references to odometry angular velocity. What do you think? |
I have no opinion. Normally this would be a discussion board post, that lead to documentation improvements. If you don't get answer here suggest you post on discuss.px4.io and cross link. |
@TSC21 Can you comment on #1376 (comment) |
Hello,
I am using mocap as an external odometry source and the body frame of the mocap markers on my drone do NOT align with the drone body frame. Marker body frame is both rotated and translated in respect to drone body frame. However, I know the transformation between mocap markers body frame and drone body frame.
I was following the instructions in external position estimation and noticed I am required to apply the transformation both in PX4 and MAVROS:
Which they are
Would someone please explain why do we need to set the transformation between mocap marker body frame and drone body frame in both PX4 and mavros? Why does PX4 need to know about this transformation, If mavros is capable of transforming the coordinate frames from mocap body frame to drone base_link?
Thank You,
Ahmad
The text was updated successfully, but these errors were encountered: