-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Multicopter PID Tuning Cookbook reformulation #2113
base: main
Are you sure you want to change the base?
Conversation
I'll review this when you mark it as ready to review.
A few thoughts:
Thanks for taking this on. I would never have got to it. |
This was done temporarily to make reviewing easier, as the diff is cleaner
Having huge docs is of course bad! With this cookbook, I want to have a clear hyperlinks in the beginning and have the user be able to go to the section they are interested in & get all the relevant information. Maybe splitting the doc into rate / attitude / velocity / position controller, etc would be nice as well. But since current doc is really not ideal for a person who really wants to tune a vehicle, this is just a starting point 👍 |
8393698
to
9c7ccdb
Compare
Rebased |
part Rename pid_multicopter to pid_multicopter_cookbook for easier Review - Previous file was interfering the view in the diff of the PR, this renames the file so that there's a clear *new-file indicator, instead of a diff, since this is in principle, a new file - As the PR gets merged, this file should be rename back to original, to restore linked connections from other docs
9c7ccdb
to
ce9144c
Compare
aea98ef
to
7d03541
Compare
Need
There are quite a few cases where a big multicopter crashed because the operator simply didn't have a good guide on how to tune the PID values.
Multicopter experts like @MaEtUgR can of course tune them properly, but this isn't well documented in our current docs, and can often lead users into confusion as the structure isn't sound.
This PR aims to bring a major reformulation on the current Multicopter PID tuning guide.
Value Proposition
Existing guide suffers from the following problems:
Therefore, this PR aims to bring in:
Other
For details, refer to the multicopter tuning guide reformulation document.