added sf45 as a seperate rangefinder #3448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
e14bb3c
to
4270c05
Compare
2 tasks
Claudio-Chies
force-pushed
the
pr-sf45
branch
from
4270c05
to
4376433
Compare
| From testing, 30 degrees is a good balance, although different vehicles may have different requirements. | ||
|
|
||
| ::: info | ||
| The guidance feature will never direct the vehicle in a direction without sensor data. | ||
| If the vehicle feels 'stuck' with only a single distance sensor pointing forwards, this is probably because the guidance cannot safely adapt the direction due to lack of information. | ||
| If the vehicle feels stuck with only a single distance sensor pointing forwards, this is probably because the guidance cannot safely adapt the direction due to lack of information. |
There was a problem hiding this comment.
FYI we only need to indicate something like "stuck" the first time, to highlight that we don't "exactly" mean stuck :-). I know this predates you, just wanted to explain why I did it.
|
This is IMO ready when your PR is ready - thanks very much!!! I did some restructure to make the new rangefinder doc a sub-doc - that allows us to expand the structure if we want in future. Note that the build error can be ignored. It happens because I moved one of the image files alongside the other, and the existing translations depend on that location. This will be fixed after merging by crowdin. |
hamishwillee
force-pushed
the
pr-sf45
branch
from
3a81a94
to
2d2246c
Compare
hamishwillee
force-pushed
the
pr-sf45
branch
from
2d2246c
to
a32bec6
Compare
|
No flaws found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PR's