Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package inquirer from 8.2.6 to 11.0.2 #2294

Open
palisadoes opened this issue Sep 23, 2024 · 5 comments
Open

Upgrade package inquirer from 8.2.6 to 11.0.2 #2294

palisadoes opened this issue Sep 23, 2024 · 5 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file question Further information is requested security Security fix test Testing application

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade the package
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Screenshot

  • The test that failed in the dependabot PR has the output in the screen shot below

image

Release Note Details

Bumps inquirer from 8.2.6 to 11.0.2.

Release notes

Sourced from inquirer's releases.

inquirer@11.0.2

  • Fix #1555: when behaviour changed unexpectedly when returning a falsy value.

inquirer@11.0.0

No technical breaking changes; but we changed the style of the question prefix once the answer is provided. Once a question is answer, the prefix becomes a tick mark (previously it was the same ? as when the prompt is idle.)

This is theme-able, and so can be overwritten to with theme.prefix.

inquirer@10.2.2

  • Fix the filter option not working.
  • The signal: AbortSignal didn't work with class based prompts (OSS plugins.) Now it should work consistently with legacy style prompts.

inquirer@10.2.1

  • Fix expand prompt being broken if a Separator was in the choices array.

inquirer@10.2.0

  • Includes various fixes & new features to the different built-in prompts
  • Fix: Major rework of the Typescript types. Hoping to reduce the amount of finicky type errors (or wrong types) you might've ran into.

inquirer@10.1.2

  • Fix broken backward compatibility issues with v9. Choice objects without value should default to use name as the value. Note: Please don't rely on this weird behaviour, but we fixed it since it was an unintended breaking change.

inquirer@10.1.0

  • Adds the new { type: 'search' } prompt.

inquirer@10.0.3

  • Fix: Re-added missing short on select and checkbox prompt.
  • Fix: Remove type requiring a close method on prompt class instances (it wasn't required.)

inquirer@10.0.0

  • Re-implemented with Typescript.
  • Adding CJS support (now inquirer is publishes a dual-build CJS/ESM.)
  • All core prompts are now coming from @inquirer/prompt.
  • Custom prompts now should be implemented with @inquirer/core. Custom prompts built on inquirer@9.x.x will keep working, but should plan a migration.
  • inquirer.ui.BottomBar is deleted.

My expectation is that this release should be a drop-in replacement for people using inquirer.prompt() and built-ins 🤞🏻. Please open an issue on Github if you run into issues migrating; it's a large rewrite and there might be a few sharp edges to cut! Hope you'll like this new release.

inquirer@9.3.5

  • Fix issue with plugins relying on internal inquirer packages file structure.

inquirer@9.3.1

  • Fix risk of prototype injection.

inquirer@9.3.0

  • Replace chalk with picolors (in 9.3.2 went to yoctocolors to stay with Sindre's packages and reduce amount of provenance.)
  • Drop many dependencies in favour of native functions when possible.

No impact expected, but it's a large changes in dependencies. Let us know if you run into any issues upgrading!

... (truncated)

Commits
  • 95674a1 Publish
  • b61337a Fix(inquirer): Fix backward compatibility issue with when returning falsy val...
  • a6ac2fa fix(inquirer): adjust parameters (#1556)
  • 9e29035 Publish
  • 9937ea0 Fix: Use strict version instead of ranges
  • 5fe03a4 Publish
  • 826ff4a Chore: Remove cli-spinners as a dependency
  • c17cd67 Chore: Bump dev dependencies
  • 407400d Chore: Make sure turbo consider new TS version when recompiling
  • aff99dd Chore: Bump Yarn
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added the bug Something isn't working label Sep 23, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file question Further information is requested security Security fix test Testing application unapproved labels Sep 23, 2024
@Abhinav232004
Copy link

@palisadoes ,Could you please assign this issue to me?

Copy link

github-actions bot commented Oct 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 7, 2024
@Aryan4884
Copy link

@varshith257 If no one is working on it, please assign me this issue.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 8, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@Aaradhy-Sharma
Copy link

Greeting, I'd love to work on this issue. I request you to assign this to me.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file question Further information is requested security Security fix test Testing application
Projects
Status: Backlog
Development

No branches or pull requests

5 participants