Slight style change in history search

[kidonng]

Proposing a slight style change in history search:

-        builtin history --null --show-time="%m-%d %H:%M:%S │ " |
-        _fzf_wrapper --read0 \
+        builtin history --null --show-time=(set_color -o)"%m-%d %H:%M:%S - "(set_color normal) |
+        _fzf_wrapper --read0 --ansi \

Preview

Motivation

• Be consistent with Search git log
• While I proposed using box-drawing characters in Use box-drawing characters instead of vertical bars as command history separator #167, I didn't find it look nice as a separator. To compensate for using dashes (-), we are making the timestamp bold to further distinguish it.

Concern

• Regarding dashes (-): this will not hinder search unless you are specifically searching for a single dash, which I honestly have no idea about.
• Regarding performance: given the relatively limited scale fish's history operate on, ANSI parsing is affordable.

---

P.S. since we are talking about timestamp format, I took the chance to answer one of your questions last year that I forgot about.

[PatrickF1]

So you want to go to dashes just because they look nicer?

Regarding dashes (-): this will not hinder search unless you are specifically searching for a single dash, which I honestly have no idea about.

Good call out. I can see this being an issue because some commands receive std input using -. If they want to search for those commands, it'll be a lot harder to.

Be consistent with Search git log

That's true but I don't see any value in being consistent with git log. If we really want to, I'd rather change the separator character used in git log to the box drawing vertical line.

[kidonng]

So you want to go to dashes just because they look nicer?

I changed my mind. I think what I really want is more distinct differences between the timestamp and the command, like bold and color (well, if it looks good to you):

Regarding dashes (-): this will not hinder search unless you are specifically searching for a single dash, which I honestly have no idea about.

Good call out. I can see this being an issue because some commands receive std input using -. If they want to search for those commands, it'll be a lot harder to.

Actually, even if nothing changes searching for a single dash won't work either, because it will always match the dash in timestamp (which is formatted as %m-%d %H:%M:%S). If this sounds like an issue to you we can discuss it elsewhere.

I'd rather change the separator character used in git log to the box drawing vertical line.

That's a welcoming change, though I would prefer to put it before the commit message, kinda like separate "meta info" from the "message" you are mostly like to search for, just like in command history.

[PatrickF1]

I changed my mind. I think what I really want is more distinct differences between the timestamp and the command, like bold and color (well, if it looks good to you):

Sure I am open to a phab changing the colors or making it bold. I'd be wary about changing the colors though because we can't assume the color scheme the user is using, and it'd be terrible if we hardcoded the same color as their background.

Actually, even if nothing changes searching for a single dash won't work either, because it will always match the dash in timestamp (which is formatted as %m-%d %H:%M:%S). If this sounds like an issue to you we can discuss it elsewhere.

Good point.

That's a welcoming change, though I would prefer to put it before the commit message, kinda like separate "meta info" from the "message" you are mostly like to search for, just like in command history.

I'll pass on that change for now.

[kidonng]

I'd be wary about changing the colors though because we can't assume the color scheme the user is using, and it'd be terrible if we hardcoded the same color as their background.

Not when using ANSI colors. And fzf.fish is using colors elsewhere.

[PatrickF1]

why don't you think ANSI colors will be a problem in that situation?

[kidonng]

Almost anything that doesn't deal with syntax highlight or themes use ANSI colors. And no sane man would set them to be the same or similar to the background (except for black/white, of course).