From c856730f94d71e45612894e3c3d4c39d7929b517 Mon Sep 17 00:00:00 2001 From: Brett Hoerner Date: Thu, 8 Feb 2024 08:09:02 -0700 Subject: [PATCH] Add histogram for insertion time to completion time (#5) * Add histogram for insertion time to completion time * Handle feedback * Oops, spurious import --- hook-worker/src/worker.rs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hook-worker/src/worker.rs b/hook-worker/src/worker.rs index 484edf7..441e1ee 100644 --- a/hook-worker/src/worker.rs +++ b/hook-worker/src/worker.rs @@ -2,6 +2,7 @@ use std::collections; use std::sync::Arc; use std::time; +use chrono::Utc; use futures::future::join_all; use hook_common::health::HealthHandle; use hook_common::pgqueue::PgTransactionBatch; @@ -234,11 +235,24 @@ async fn process_webhook_job( match send_result { Ok(_) => { + let created_at = webhook_job.job().created_at; + let retries = webhook_job.job().attempt - 1; + let labels_with_retries = [ + ("queue", webhook_job.queue()), + ("retries", retries.to_string()), + ]; + webhook_job.complete().await.map_err(|error| { metrics::counter!("webhook_jobs_database_error", &labels).increment(1); error })?; + let insert_to_complete_duration = Utc::now() - created_at; + metrics::histogram!( + "webhook_jobs_insert_to_complete_duration_seconds", + &labels_with_retries + ) + .record((insert_to_complete_duration.num_milliseconds() as f64) / 1_000_f64); metrics::counter!("webhook_jobs_completed", &labels).increment(1); metrics::histogram!("webhook_jobs_processing_duration_seconds", &labels) .record(elapsed);