Typescript Rewrite

[adambrangenberg]

Hey, I opened this discussion because:

1. I'm not sure in what order to rewrite things to get the types of the basis while creating ones for higher packages?
2. If the project even wants to use Typescript?

The benefits of using Typescript would be a higher code quality because with static typing many bugs are being catched while developing and easier development because of improved editor support and documentation.

[rom1504]

Hi, Typescript has a high entry cost (compilation making everything slower and making usage of dependencies harder) and low benefits. If you manage to make the code much higher quality by rewriting a significant package to it, it might be convincing. Otherwise we're staying in JavaScript.

…

On Sun, Mar 5, 2023, 02:45 Adam Brangenberg ***@***.***> wrote: Hey, I opened this discussion because: 1. I'm not sure in what order to rewrite things to get the types of the basis while creating ones for higher packages? 2. If the project even wants to use Typescript? The benefits of using Typescript would be a higher code quality because with static typing many bugs are being catched while developing and easier development because of improved editor support and documentation. — Reply to this email directly, view it on GitHub <#2964>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437SC5FVWZ3GMSXJYXADW2PV37ANCNFSM6AAAAAAVP3YB6Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[adambrangenberg]

Okay, can you recommend any module to do that?
Edit: There are a few tools that compile pretty fast, like swc or the regular typescript compiler. So I'm not sure what you mean by that?

[rom1504]

Probably mineflayer

[adambrangenberg]

Hey, I've ran into a few issues like some dependencies not having used methods implemented (e.g. anvil.js using .close from prismarine-windows, which doesn't seem to have such method). Do you know anything about why that is? It's hard to implement types for things that seem to be non-existent :/

[AugustinMauroy]

If we rewrite it we should use ESM import/export

[AugustinMauroy]

@rom1504 Create an branch name major/typescript. To allow the contributor to code.

[adambrangenberg]

That would be great. I already did the anvil module, but still waiting for the typing in prismarine-item to get merged.

[AugustinMauroy]

WDYM by typing? migrate to typescript or use just type ?

[adambrangenberg]

Exporting some things, etc: PrismarineJS/prismarine-item#87