Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Ethereum sha3 crypto library blocks import of this repository #47

Open
PeterCCLiu opened this issue Jul 14, 2021 · 0 comments

Comments

@PeterCCLiu
Copy link

In file curves/altbn128.go, the authors import the deprecated ethereum sha3 crypto library for compatibility.
gosha3 "github.com/ethereum/go-ethereum/crypto/sha3"

This library is removed by ethereum, as stated in here. Now regarding sha3 use, ethereum all moves on to golang.org/x/crypto/sha3 instead.

Keeping this deprecated import causes fail in

  • go get github.com/ethereum/go-ethereum/crypto/sha3 within this project
  • import . "github.com/Project-Arda/bgls/curves" from another project

Request to delete this import line and function EthereumSum256 in curves/altbn128.go, please. Or I can create a PR for that.

Best,
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant