Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the RegisterFromNodeAnnotations code to make it clearer. Enhance its readability. #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Jan 23, 2024

  1. Increase the commonts of the code.
  2. Merge duplicate codes into functions.
  3. Reduce the nesting level of if statements.

@archlitchi
Copy link
Collaborator

thanks for refining these code, have you tested?

@haitwang-cloud
Copy link
Contributor

As a user for the k8s-vgpu-scheduler , I would suggest that @chaunceyjiang could add more UT for your code change to ensure that the new code is fully tested.

@chaunceyjiang
Copy link
Contributor Author

have you tested?

I am currently testing. I will post the test results later.

@chaunceyjiang
Copy link
Contributor Author

As a user for the k8s-vgpu-scheduler , I would suggest that @chaunceyjiang could add more UT for your code change to ensure that the new code is fully tested.

Good idea.

However, this project currently lacks the corresponding GitHub action( golang-lint, UT, E2E, etc.), but I will supplement the UT later.

@haitwang-cloud
Copy link
Contributor

As a user for the k8s-vgpu-scheduler , I would suggest that @chaunceyjiang could add more UT for your code change to ensure that the new code is fully tested.

Good idea.

However, this project currently lacks the corresponding GitHub action( golang-lint, UT, E2E, etc.), but I will supplement the UT later.
Good to know that ,I am working on build the UTs and E2E test case for the code 2.

@chaunceyjiang
Copy link
Contributor Author

Good to know that ,I am working on build the UTs and E2E test case for the code 2.

Amazing!

@archlitchi
Copy link
Collaborator

please resolve this conflict first :)

…ance its readability.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Contributor Author

image

Use the latest dev image.

image

The GPU pod can be scheduled normally.

image
The scheduler log is also normal.

@chaunceyjiang
Copy link
Contributor Author

/cc @archlitchi PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants