add vendor-check to github actions #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaunceyjiang
force-pushed
the
lint_action
branch
from
4709d0b
to
64ffdb1
Compare
chaunceyjiang
force-pushed
the
lint_action
branch
4 times, most recently
from
422e82e
to
23f4035
Compare
chaunceyjiang
force-pushed
the
lint_action
branch
from
23f4035
to
29f9fe7
Compare
|
Including vendor in the project seems to be a best practice for many open source projects such as This allows building and compiling in any environment without external code dependencies. |
chaunceyjiang
force-pushed
the
lint_action
branch
3 times, most recently
from
09b76ed
to
e4a8e8b
Compare
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
force-pushed
the
lint_action
branch
from
e4a8e8b
to
05dadcb
Compare
chaunceyjiang
changed the title
|
/lgtm look good to me /cc @archlitchi PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced the
vendordirectory because, based on my experience, incorporating this directory intogitallows for a quick review ofchangesin a certaindependency librarywithout needing to browse through upstream code.