Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyspice examples are not included in pre-release testing #366

Open
wahuneke opened this issue Feb 13, 2024 · 0 comments
Open

Pyspice examples are not included in pre-release testing #366

wahuneke opened this issue Feb 13, 2024 · 0 comments

Comments

@wahuneke
Copy link

Using the latest release, there are some minor errors in some of the examples (e.g. matplotlib compatibility). This raises the general question:

as part of pre-release test, would you like examples to be run and some cursory confirmation performed ?

Has this idea already been considered and rejected for some reason? If not, I propose I go ahead with something like the following.

Proposal

Add a unit test which attempts to run each example. For each one perform cursory checks - at least confirm that the it ran without exceptions. As an added feature, we could consider confirming (for examples where this applies) that plot files were successfully generated and that they meet some basic requirement (non-zero size?). The goal would be to provide a minimal sanity check

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant