-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus: fix job option usage at user level #5255
base: develop
Are you sure you want to change the base?
Conversation
Thanks Jaron.
|
Option (+other) data can be shared at the top of the Nexus file. This is often how large scripts are handled, and/or ones meant to run on multiple machines. Here is an example of three pwscf jobs across two machines that share software and runtime/submission options:
|
Test this please |
Does this PR fix the CI failure in #5240? |
This PR should not cause the CI to fail. Nexus behaves in the same way as before (and all tests pass). Instead, it should open the way to allow usage of flags to mpirun as needed per machine environment. |
I would like to request documentation is added. I am concerned at the relative rate of growth of Nexus functionality vs growth of the documentation. An example like the above plus suitable discussion would be a good addition imo, and also improve discoverability of the functionality. |
Proposed changes
This PR improves job option handling in Nexus, making the interface often used at the Machine level available at the user level.
For example, to achieve what is desired in #5240, the following input can be used:
This results in a call to mpirun like:
These forms are now equivalent:
All current tests pass.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop
Checklist