From 4942d2dbc85f193c53a37bdfbfb4e594073b0b43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Eddybrando=20Va=CC=81squez?= <eddybrando.vasquez@gmail.com>
Date: Fri, 28 Jul 2023 11:50:35 +0200
Subject: [PATCH] refactor(layout): make "default-max" the default

---
 layouts/default-max.vue                       | 35 -------------------
 layouts/default.vue                           | 18 ++++++----
 pages/advocates.vue                           |  1 -
 pages/ecosystem.vue                           |  1 -
 pages/events/fall-fest.vue                    |  2 --
 pages/events/index.vue                        |  4 ---
 pages/events/seminar-series.vue               |  1 -
 pages/events/summer-school-2022.vue           |  1 -
 pages/events/summer-school-2023.vue           |  1 -
 pages/index.vue                               |  1 -
 pages/learn/course/algorithm-design.vue       |  1 -
 .../course/basics-quantum-information.vue     |  1 -
 .../fundamentals-quantum-algorithms.vue       |  1 -
 pages/learn/course/games-and-demos.vue        |  1 -
 pages/learn/course/introduction-course.vue    |  1 -
 pages/learn/course/legacy-content.vue         |  1 -
 .../learn/course/machine-learning-course.vue  |  1 -
 .../multiple-qubits-and-entanglement.vue      |  1 -
 pages/learn/course/prerequisites.vue          |  1 -
 .../quantum-algorithms-for-applications.vue   |  1 -
 pages/learn/course/quantum-computing-labs.vue |  1 -
 .../course/quantum-hardware-circuits.vue      |  1 -
 .../learn/course/quantum-hardware-pulses.vue  |  1 -
 ...antum-protocols-and-quantum-algorithms.vue |  1 -
 .../course/quantum-states-and-qubits.vue      |  1 -
 pages/learn/index.vue                         |  1 -
 ...um-computing-and-quantum-hardware-2020.vue |  1 -
 ...um-computing-and-quantum-learning-2021.vue |  1 -
 .../quantum-simulation-summer-school-2022.vue |  1 -
 pages/providers.vue                           |  1 -
 30 files changed, 11 insertions(+), 74 deletions(-)
 delete mode 100644 layouts/default-max.vue

diff --git a/layouts/default-max.vue b/layouts/default-max.vue
deleted file mode 100644
index ac86408bdc..0000000000
--- a/layouts/default-max.vue
+++ /dev/null
@@ -1,35 +0,0 @@
-<template>
-  <div>
-    <header>
-      <qiskit-ui-shell v-if="isALearningPage" @on-click="onClick" />
-      <qiskit-ui-shell v-else variant="hide-account" @on-click="onClick" />
-    </header>
-    <main class="main">
-      <slot />
-    </main>
-    <LayoutFooter theme="light" />
-  </div>
-</template>
-
-<script setup lang="ts">
-// import "@qiskit/web-components/ui-shell";
-
-const route = useRoute();
-const { trackClickEvent } = useSegment();
-
-function onClick(e: CustomEvent) {
-  trackClickEvent(`${e.detail?.label?.toLowerCase()}`, "menu");
-}
-
-const isALearningPage = computed(() => route.path.includes("/learn"));
-</script>
-
-<style lang="scss" scoped>
-.main {
-  margin-top: 3.25rem;
-}
-
-qiskit-ui-shell {
-  --header-content-max-width: 96rem;
-}
-</style>
diff --git a/layouts/default.vue b/layouts/default.vue
index a75cc504a0..1867d41d82 100644
--- a/layouts/default.vue
+++ b/layouts/default.vue
@@ -1,25 +1,29 @@
 <template>
   <div>
-    <qiskit-ui-shell variant="hide-account" @on-click="onClick" />
-    <div class="main-container">
+    <header>
+      <qiskit-ui-shell v-if="isALearningPage" @on-click="onClick" />
+      <qiskit-ui-shell v-else variant="hide-account" @on-click="onClick" />
+    </header>
+    <main class="main">
       <slot />
-    </div>
-    <LayoutFooter old-container theme="light" />
+    </main>
+    <LayoutFooter />
   </div>
 </template>
 
 <script setup lang="ts">
-// import "@qiskit/web-components/ui-shell";
-
+const route = useRoute();
 const { trackClickEvent } = useSegment();
 
 function onClick(e: CustomEvent) {
   trackClickEvent(`${e.detail?.label?.toLowerCase()}`, "menu");
 }
+
+const isALearningPage = computed(() => route.path.includes("/learn"));
 </script>
 
 <style lang="scss" scoped>
-.main-container {
+.main {
   margin-top: 3.25rem;
 }
 
diff --git a/pages/advocates.vue b/pages/advocates.vue
index 593c626dff..a79afe54b6 100644
--- a/pages/advocates.vue
+++ b/pages/advocates.vue
@@ -14,7 +14,6 @@
 
 <script setup lang="ts">
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Advocates",
   routeName: "advocates",
 });
diff --git a/pages/ecosystem.vue b/pages/ecosystem.vue
index 34a49b3041..4ede2a7fb5 100644
--- a/pages/ecosystem.vue
+++ b/pages/ecosystem.vue
@@ -148,7 +148,6 @@ const joinAction: TextLink = {
 };
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Ecosystem",
   routeName: "ecosystem",
 });
diff --git a/pages/events/fall-fest.vue b/pages/events/fall-fest.vue
index aa8da15389..38f445831c 100644
--- a/pages/events/fall-fest.vue
+++ b/pages/events/fall-fest.vue
@@ -100,7 +100,6 @@
 </template>
 
 <script setup lang="ts">
-// import "@carbon/web-components/es/components/tabs/index.js";
 import {
   header,
   agenda,
@@ -108,7 +107,6 @@ import {
 } from "~/constants/fallFest2022Content";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Fall Fest 2022",
   routeName: "fall-fest",
 });
diff --git a/pages/events/index.vue b/pages/events/index.vue
index 8da31e9cc2..c3f9d4387c 100644
--- a/pages/events/index.vue
+++ b/pages/events/index.vue
@@ -113,9 +113,6 @@
 </template>
 
 <script setup lang="ts">
-// import "@carbon/web-components/es/components/checkbox/index.js";
-// import "@carbon/web-components/es/components/code-snippet/index.js";
-// import "@carbon/web-components/es/components/tabs/index.js";
 import {
   CommunityEvent,
   WORLD_REGION_OPTIONS,
@@ -128,7 +125,6 @@ import rawUpcomingEvents from "~/content/events/upcoming-community-events.json";
 type TabActiveSet = "calendar" | "past" | "upcoming";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Events",
   routeName: "events",
 });
diff --git a/pages/events/seminar-series.vue b/pages/events/seminar-series.vue
index 580610e232..a2b8e319b7 100644
--- a/pages/events/seminar-series.vue
+++ b/pages/events/seminar-series.vue
@@ -123,7 +123,6 @@ import { TextLink } from "~/types/links";
 import { DescriptionCard, MosaicElement } from "~/types/uiComponents";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Seminar Series",
   routeName: "seminar-series",
 });
diff --git a/pages/events/summer-school-2022.vue b/pages/events/summer-school-2022.vue
index a0494835a2..00b337e3a9 100644
--- a/pages/events/summer-school-2022.vue
+++ b/pages/events/summer-school-2022.vue
@@ -110,7 +110,6 @@ import {
 } from "~/constants/summerSchool2022Content";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Global Summer School 2022",
   routeName: "summer-school-2022",
 });
diff --git a/pages/events/summer-school-2023.vue b/pages/events/summer-school-2023.vue
index c5d863d166..3da311a9eb 100644
--- a/pages/events/summer-school-2023.vue
+++ b/pages/events/summer-school-2023.vue
@@ -121,7 +121,6 @@ import {
 } from "~/constants/summerSchool2023Content";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Global Summer School 2023",
   routeName: "/events/summer-school-2023",
 });
diff --git a/pages/index.vue b/pages/index.vue
index 6f242ba0a2..5ff522acca 100644
--- a/pages/index.vue
+++ b/pages/index.vue
@@ -15,7 +15,6 @@ interface PackageInfo {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit",
   routeName: "qiskit-landing-page",
 });
diff --git a/pages/learn/course/algorithm-design.vue b/pages/learn/course/algorithm-design.vue
index f439f512b9..69cf4a8ef0 100644
--- a/pages/learn/course/algorithm-design.vue
+++ b/pages/learn/course/algorithm-design.vue
@@ -23,7 +23,6 @@ import { RecommendedReading } from "~/types/learn";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Variational Algorithm Design",
   routeName: "algorithm-design",
 });
diff --git a/pages/learn/course/basics-quantum-information.vue b/pages/learn/course/basics-quantum-information.vue
index 6df35bf8a0..09779a439c 100644
--- a/pages/learn/course/basics-quantum-information.vue
+++ b/pages/learn/course/basics-quantum-information.vue
@@ -23,7 +23,6 @@ import { RecommendedReading } from "~/types/learn";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Basics of quantum information",
   routeName: "basics-quantum-information-course",
 });
diff --git a/pages/learn/course/fundamentals-quantum-algorithms.vue b/pages/learn/course/fundamentals-quantum-algorithms.vue
index 90dde3e2c9..b80cc941f9 100644
--- a/pages/learn/course/fundamentals-quantum-algorithms.vue
+++ b/pages/learn/course/fundamentals-quantum-algorithms.vue
@@ -23,7 +23,6 @@ import { RecommendedReading } from "~/types/learn";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Fundamentals of quantum algorithms",
   routeName: "fundamentals-quantum-algorithms-course",
 });
diff --git a/pages/learn/course/games-and-demos.vue b/pages/learn/course/games-and-demos.vue
index d585896331..ad47cce257 100644
--- a/pages/learn/course/games-and-demos.vue
+++ b/pages/learn/course/games-and-demos.vue
@@ -29,7 +29,6 @@ enum GamesAndDemosUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Games and demos",
   routeName: "games-and-demos",
 });
diff --git a/pages/learn/course/introduction-course.vue b/pages/learn/course/introduction-course.vue
index 6704b3bcb2..8f1b24cb74 100644
--- a/pages/learn/course/introduction-course.vue
+++ b/pages/learn/course/introduction-course.vue
@@ -23,7 +23,6 @@ import { RecommendedReading } from "~/types/learn";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Introduction course",
   routeName: "introduction-course",
 });
diff --git a/pages/learn/course/legacy-content.vue b/pages/learn/course/legacy-content.vue
index 9bf71d297d..29ac6c4a1a 100644
--- a/pages/learn/course/legacy-content.vue
+++ b/pages/learn/course/legacy-content.vue
@@ -34,7 +34,6 @@ enum LegacyContentUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Legacy content",
   routeName: "legacy-content",
 });
diff --git a/pages/learn/course/machine-learning-course.vue b/pages/learn/course/machine-learning-course.vue
index 490bfabb61..4bc9fa7f56 100644
--- a/pages/learn/course/machine-learning-course.vue
+++ b/pages/learn/course/machine-learning-course.vue
@@ -22,7 +22,6 @@ import { LearnStartLearningUrl } from "~/constants/links";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Quantum machine learning course",
   routeName: "machine-learning-course",
 });
diff --git a/pages/learn/course/multiple-qubits-and-entanglement.vue b/pages/learn/course/multiple-qubits-and-entanglement.vue
index dbab62a991..91da18e138 100644
--- a/pages/learn/course/multiple-qubits-and-entanglement.vue
+++ b/pages/learn/course/multiple-qubits-and-entanglement.vue
@@ -31,7 +31,6 @@ enum MultipleQubitsAndEntanglementUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Multiple Qubits and Entanglement",
   routeName: "multiple-qubits-and-entanglement",
 });
diff --git a/pages/learn/course/prerequisites.vue b/pages/learn/course/prerequisites.vue
index 001633b6d9..ea93edbe56 100644
--- a/pages/learn/course/prerequisites.vue
+++ b/pages/learn/course/prerequisites.vue
@@ -27,7 +27,6 @@ enum PrerequisitesUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Prerequisites",
   routeName: "prerequisites",
 });
diff --git a/pages/learn/course/quantum-algorithms-for-applications.vue b/pages/learn/course/quantum-algorithms-for-applications.vue
index 9b7f8f434c..d3df948b56 100644
--- a/pages/learn/course/quantum-algorithms-for-applications.vue
+++ b/pages/learn/course/quantum-algorithms-for-applications.vue
@@ -34,7 +34,6 @@ enum QuantumAlgorithmsForApplicationsUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Quantum Algorithms for Applications",
   routeName: "quantum-algorithms-for-applications",
 });
diff --git a/pages/learn/course/quantum-computing-labs.vue b/pages/learn/course/quantum-computing-labs.vue
index 9ed46392d2..e95d1fab3b 100644
--- a/pages/learn/course/quantum-computing-labs.vue
+++ b/pages/learn/course/quantum-computing-labs.vue
@@ -34,7 +34,6 @@ enum QuantumComputingLabsUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Quantum Computing Labs",
   routeName: "quantum-computing-labs",
 });
diff --git a/pages/learn/course/quantum-hardware-circuits.vue b/pages/learn/course/quantum-hardware-circuits.vue
index d1e2269c80..c263b226c8 100644
--- a/pages/learn/course/quantum-hardware-circuits.vue
+++ b/pages/learn/course/quantum-hardware-circuits.vue
@@ -29,7 +29,6 @@ enum QuantumHardwareCircuitsUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Investigating Quantum Hardware Using Quantum Circuits",
   routeName: "quantum-hardware-circuits",
 });
diff --git a/pages/learn/course/quantum-hardware-pulses.vue b/pages/learn/course/quantum-hardware-pulses.vue
index 1d65fe7260..7329f59db1 100644
--- a/pages/learn/course/quantum-hardware-pulses.vue
+++ b/pages/learn/course/quantum-hardware-pulses.vue
@@ -31,7 +31,6 @@ enum QuantumHardwarePulsesUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Investigating Quantum Hardware Using Microwave Pulses",
   routeName: "quantum-hardware-pulses",
 });
diff --git a/pages/learn/course/quantum-protocols-and-quantum-algorithms.vue b/pages/learn/course/quantum-protocols-and-quantum-algorithms.vue
index f75d7dabff..6b12f6db05 100644
--- a/pages/learn/course/quantum-protocols-and-quantum-algorithms.vue
+++ b/pages/learn/course/quantum-protocols-and-quantum-algorithms.vue
@@ -39,7 +39,6 @@ enum QuantumProtocolsAndQuantumAlgorithmsUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Quantum Protocols and Quantum Algorithms",
   routeName: "quantum-protocols-and-quantum-algorithms",
 });
diff --git a/pages/learn/course/quantum-states-and-qubits.vue b/pages/learn/course/quantum-states-and-qubits.vue
index e7604f602d..7aeaedabe0 100644
--- a/pages/learn/course/quantum-states-and-qubits.vue
+++ b/pages/learn/course/quantum-states-and-qubits.vue
@@ -30,7 +30,6 @@ enum QuantumStatesAndQubitsUrl {
 }
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Quantum States and Qubits",
   routeName: "quantum-states-and-qubits",
 });
diff --git a/pages/learn/index.vue b/pages/learn/index.vue
index 8be7c80e16..c414627d55 100644
--- a/pages/learn/index.vue
+++ b/pages/learn/index.vue
@@ -14,7 +14,6 @@ import { SocialMedia } from "~/constants/links";
 import { DescriptionCard } from "~/types/uiComponents";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Textbook",
   routeName: "learn",
 });
diff --git a/pages/learn/summer-school/introduction-to-quantum-computing-and-quantum-hardware-2020.vue b/pages/learn/summer-school/introduction-to-quantum-computing-and-quantum-hardware-2020.vue
index 246a681c39..a172fb3758 100644
--- a/pages/learn/summer-school/introduction-to-quantum-computing-and-quantum-hardware-2020.vue
+++ b/pages/learn/summer-school/introduction-to-quantum-computing-and-quantum-hardware-2020.vue
@@ -22,7 +22,6 @@ import { LearnStartLearningUrl } from "~/constants/links";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle:
     "2020 Qiskit global summer school on quantum computing and quantum hardware",
   routeName: "introduction-to-quantum-computing-and-quantum-hardware-2020",
diff --git a/pages/learn/summer-school/quantum-computing-and-quantum-learning-2021.vue b/pages/learn/summer-school/quantum-computing-and-quantum-learning-2021.vue
index 38e4870a5c..563de1d526 100644
--- a/pages/learn/summer-school/quantum-computing-and-quantum-learning-2021.vue
+++ b/pages/learn/summer-school/quantum-computing-and-quantum-learning-2021.vue
@@ -23,7 +23,6 @@ import { RecommendedReading } from "~/types/learn";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "2021 Qiskit Global Summer School on Quantum Machine Learning",
   routeName: "quantum-computing-and-quantum-learning-2021",
 });
diff --git a/pages/learn/summer-school/quantum-simulation-summer-school-2022.vue b/pages/learn/summer-school/quantum-simulation-summer-school-2022.vue
index 3216d92db0..36e5a91cf1 100644
--- a/pages/learn/summer-school/quantum-simulation-summer-school-2022.vue
+++ b/pages/learn/summer-school/quantum-simulation-summer-school-2022.vue
@@ -22,7 +22,6 @@ import { LearnStartLearningUrl } from "~/constants/links";
 import { TextLink } from "~/types/links";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "2022 Qiskit global summer school on quantum simulation",
   routeName: "quantum-simulation-summer-school-2022",
 });
diff --git a/pages/providers.vue b/pages/providers.vue
index ca64d38dc7..1891402daf 100644
--- a/pages/providers.vue
+++ b/pages/providers.vue
@@ -70,7 +70,6 @@ import {
 } from "~/types/providers";
 
 definePageMeta({
-  layout: "default-max",
   pageTitle: "Qiskit Providers",
   routeName: "providers",
 });