Fix tracedist #495
Merged
Fix tracedist #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
==========================================
- Coverage 89.03% 87.74% -1.30%
==========================================
Files 83 87 +4
Lines 4835 5264 +429
==========================================
+ Hits 4305 4619 +314
- Misses 530 645 +115 ☔ View full report in Codecov by Sentry. |
GiggleLiu
reviewed
Feb 28, 2024
Makefile
Outdated
| @@ -0,0 +1,37 @@ | |||
| JL = julia --project | |||
|
|
|||
| default: init test | |||
There was a problem hiding this comment.
Please do not commit this Makefile. It has already been included in another PR.
There was a problem hiding this comment.
sure I can remove it
|
@Roger-luo It makes sense to me, what is your opinion? |
Roger-luo
reviewed
Feb 28, 2024
|
LGTM. Thanks, @exAClior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current calculation of trace distance is off by a factor of 1/2. Now the result matches wiki's and documentation's definition