Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis url is not honored even when specified in the config #15

Open
yatharthranjan opened this issue Jul 4, 2020 · 4 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@yatharthranjan
Copy link
Member

The python module does not honor the redis URL mentioned in the config and always uses localhost (the default). Investigate and fix this.

@yatharthranjan yatharthranjan added the bug Something isn't working label Jul 4, 2020
@yatharthranjan yatharthranjan added the good first issue Good for newcomers label Nov 2, 2020
@Hsankesara
Copy link
Member

Hi Yatharth, I'd like to work on this issue, reproduce the bug and fix it.

@yatharthranjan
Copy link
Member Author

Hi @Hsankesara , sure. To reproduce it, set the Redis URL to something different in the config file. It will still take it up as localhost no matter what is configured. It could be using one of the default values for parameters in init (possibly in the Connection and Publisher classes).

@Hsankesara
Copy link
Member

Thanks @yatharthranjan, I changed the host in redis_publisher in config.yaml from localhost to xyz but I got connection error and it didn't use localhost for connection.

@yatharthranjan
Copy link
Member Author

Yes, that is right, this happens 2 times at startup, the first time it takes the correct URL from the config and hence you see the error, but if you get past the error, this will happen a second time, and this time it will use localhost. Can you try that?
You can add a new host binding on your system by editing /etc/hosts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants