Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] it's not proper to define RISCV_S_MODE in bsp level #9670

Open
unicornx opened this issue Nov 19, 2024 · 1 comment · May be fixed by #9718
Open

[Bug] it's not proper to define RISCV_S_MODE in bsp level #9670

unicornx opened this issue Nov 19, 2024 · 1 comment · May be fixed by #9718
Assignees
@WwWangGuan
Labels
Arch: RISC-V BSP related with risc-v BSP: Cvitek BSP related with cvitek BSP RT-Smart RT-Thread Smart related PR or issues

Comments

@unicornx
Copy link
Contributor

RT-Thread Version

master

Hardware Type/Architectures

bsp/qemu-virt64-riscv

Develop Toolchain

Other

Describe the bug

搜索 RISCV_S_MODE 会发现这个宏开关影响的是 libcpu 层级的代码。

可是目前这个配置开关却定义在 bsp/qemu-virt64-riscv/driver/Kconfig，这是不合理的。

应该定义在内核 libcpu 中，bsp 使用（select） 就好了。

Other additional context

No response
@unicornx unicornx self-assigned this Nov 19, 2024
@unicornx unicornx added BSP BSP: Cvitek BSP related with cvitek Arch: RISC-V BSP related with risc-v RT-Smart RT-Thread Smart related PR or issues labels Nov 19, 2024
This was referenced Nov 27, 2024
Closed
Open
@WwWangGuan
Copy link
Contributor

issue补领一下，感谢

@unicornx unicornx assigned WwWangGuan and unassigned unicornx Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WwWangGuan WwWangGuan

Labels
Arch: RISC-V BSP related with risc-v BSP: Cvitek BSP related with cvitek BSP RT-Smart RT-Thread Smart related PR or issues
Projects
None yet
Milestone
No milestone
2 participants
@unicornx @WwWangGuan