Skip to content
This repository has been archived by the owner on Mar 12, 2019. It is now read-only.

resized image get a .jpg extension on iOS ( params.filename has no extension) but not on android #25

Open
lovelyelfpop opened this issue Dec 2, 2015 · 2 comments

Comments

@lovelyelfpop
Copy link
Contributor

com.raananw.imageResizer\src\ios\ImageResize.m

NSRange r = [filename rangeOfString:format options:NSCaseInsensitiveSearch]; //removed
if (r.location == NSNotFound) {
[fullFileName appendString:@"."];
[fullFileName appendString:format];
}

I think the code above should be removed

@RaananW
Copy link
Owner

RaananW commented Dec 2, 2015

Hi,

I am not sure which one of the two is a bug. From the title I thought the bug was on Android, but from the description I understand the bug is in iOS. The problem is that the extension IS being added, or not being added?
Because I actually think that it is better to add the extension. But if you have a different point of view, please share it.

@lovelyelfpop
Copy link
Contributor Author

@RaananW I think it's better not to add the extension. The output file name should be determined by the param "params.filename".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants