Issue caused by functionCache in the Function class

[chsword]

Bug Report

Issue caused by functionCache in the Function class:

In the same project, when using the same Function.Name in different processes with different parameters and descriptions, the functionCache causes this situation to be unhandled.

[StephenHodgson]

You cannot use the same name for different functions. They should have unique names

[chsword]

If The definition of the function is loaded from the database. If we use static to cache the function definition, we would need to clear the cache every time the function is modified.

[StephenHodgson]

@chsword you can use Tool.ClearRegisteredTools();

But tbh if you're using a database you probably ought to also be using cloud functions

[Muleskinner]

I have the same issue which started to occur after the latest update. This for example now throws the error "The function functionname is already registered" when called twice from two different processes:

List<Function> f = new List<Function>
    {
    new Function(
        functionName,
        functionDescription,
        parameters
    )
 };

I noticed that the GetOrCreateFunction method, which could help me avoid this issue, is defined as internal. Is there a recommended way to check if a function with a given name already exists in the function cache, considering the method is internal?

[StephenHodgson]

I think it makes sense to possibly make that GetOrCreateFunction public

[StephenHodgson]

@Muleskinner I will not be making Function.GetOrCreateFunction public, but you can use Tool.GetOrCreateTool which is more appropriate.

[StephenHodgson]

Also you should be using a list of Tools not Functions:

List<Tool> tools = new List<Tools>
{
    new Function(
        functionName,
        functionDescription,
        parameters)
};