From 0d7881ded0031e377b32d8eecefeccb71978df04 Mon Sep 17 00:00:00 2001
From: Osip Fatkullin <o.fatkullin@redmadrobot.com>
Date: Mon, 27 Jun 2022 09:44:54 +0300
Subject: [PATCH] feat: Add validateCatalog to check task

---
 .../src/main/kotlin/ValidateVersionCatalogTask.kt  | 10 ++++++++--
 .../main/kotlin/VersionCatalogExtensionsPlugin.kt  | 14 +++++++++++---
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/version-catalog-extensions/src/main/kotlin/ValidateVersionCatalogTask.kt b/version-catalog-extensions/src/main/kotlin/ValidateVersionCatalogTask.kt
index 8c86c89..d885158 100644
--- a/version-catalog-extensions/src/main/kotlin/ValidateVersionCatalogTask.kt
+++ b/version-catalog-extensions/src/main/kotlin/ValidateVersionCatalogTask.kt
@@ -10,12 +10,18 @@ import org.gradle.api.provider.Property
 import org.gradle.api.tasks.Input
 import org.gradle.api.tasks.TaskAction
 import org.gradle.kotlin.dsl.named
+import org.gradle.language.base.plugins.LifecycleBasePlugin
 
 abstract class ValidateVersionCatalogTask : DefaultTask() {
 
     @get:Input
     abstract val dependenciesModel: Property<DefaultVersionCatalog>
 
+    init {
+        group = LifecycleBasePlugin.VERIFICATION_GROUP
+        description = "Validates version catalog"
+    }
+
     @TaskAction
     fun validate() {
         val catalog = dependenciesModel.get()
@@ -23,10 +29,10 @@ abstract class ValidateVersionCatalogTask : DefaultTask() {
         // Check libraries in catalog are resolvable
         val configuration = createConfiguration()
         configuration.addLibraries(catalog)
-        println("Resolved dependencies:")
+        logger.debug("Resolved dependencies:")
         configuration.resolvedConfiguration
             .firstLevelModuleDependencies
-            .forEach { println("- ${it.name}") }
+            .forEach { logger.debug("- ${it.name}") }
 
         catalog.checkVersionsUsed()
     }
diff --git a/version-catalog-extensions/src/main/kotlin/VersionCatalogExtensionsPlugin.kt b/version-catalog-extensions/src/main/kotlin/VersionCatalogExtensionsPlugin.kt
index 94a9a6e..661081f 100644
--- a/version-catalog-extensions/src/main/kotlin/VersionCatalogExtensionsPlugin.kt
+++ b/version-catalog-extensions/src/main/kotlin/VersionCatalogExtensionsPlugin.kt
@@ -2,16 +2,24 @@ package com.redmadrobot.gradle.catalog
 
 import org.gradle.api.Plugin
 import org.gradle.api.Project
+import org.gradle.api.plugins.catalog.VersionCatalogPlugin.GENERATE_CATALOG_FILE_TASKNAME
 import org.gradle.api.plugins.catalog.internal.CatalogExtensionInternal
 import org.gradle.kotlin.dsl.getByName
 import org.gradle.kotlin.dsl.register
+import org.gradle.language.base.plugins.LifecycleBasePlugin.CHECK_TASK_NAME
 
 class VersionCatalogExtensionsPlugin : Plugin<Project> {
 
-    override fun apply(target: Project) {
-        val extension = target.extensions.getByName<CatalogExtensionInternal>("catalog")
-        target.tasks.register<ValidateVersionCatalogTask>("validateCatalog") {
+    override fun apply(target: Project) = with(target) {
+        val extension = extensions.getByName<CatalogExtensionInternal>("catalog")
+        val validateCatalog = tasks.register<ValidateVersionCatalogTask>(VALIDATE_CATALOG_TASK_NAME) {
             dependenciesModel.set(extension.versionCatalog)
+            dependsOn(tasks.named(GENERATE_CATALOG_FILE_TASKNAME))
         }
+        tasks.named(CHECK_TASK_NAME).configure { dependsOn(validateCatalog) }
+    }
+
+    companion object {
+        const val VALIDATE_CATALOG_TASK_NAME = "validateCatalog"
     }
 }