Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore should not be placed in Repositories #8

Open
pedromassango opened this issue Apr 24, 2020 · 2 comments
Open

Firestore should not be placed in Repositories #8

pedromassango opened this issue Apr 24, 2020 · 2 comments

Comments

@pedromassango
Copy link

pedromassango commented Apr 24, 2020 •
edited
Loading

Firestore should not be placed in Repositories instead it should be abstracted into something like FirestoreService.

Edit:

Reference: Service Abstraction
@ResoDev
Copy link
Contributor

ResoDev commented May 4, 2020

This is a fair point. At the same time, working with Firestore is much easier and less boilerplatey than doing HTTP requests. That's why I decided to omit the lowest layer of abstraction.
In the end, repository implementation is still within the infrastructure layer so we're not breaking the boundaries laid out by DDD 😜

@pedromassango
Copy link
Author

This is what I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ResoDev @pedromassango