Require bracketting when detecting floating point size in code notes.

[redwizard42]

Code notes will very greedily take any instances of the letters FLOAT next to each other and treat the address as a 32-bit floating point (single precision) size. Those letters frequently are meant to be a word in the note's description rather than size, which can lead to oddness like "[8bit] Fish Up the Cat floater" being treated as a floating point. My suggestion would be to only treat those letters as a floating point size if they are the sole letters in a word, and also included in brackets of some kind (any kind).

Summary:

• Exclude any words that are not solely 'float': Floating, Floater, Floated, etc.
• Require some sort of bracketing: parentheses, square brackets to surround it. Ex: (float) [float]

[Jamiras]

Exclude any words that are not solely 'float': Floating, Floater, Floated, etc.

This already occurs. "float" must appear as a singular word, with a non-alphabetic character (or end of string) on both sides. Here are tests cases illustrating:

RAIntegration/tests/data/models/CodeNotesModel_Tests.cpp

Lines 232 to 238 in 37ae6dd

	TestCodeNoteSize(L"[float] Test", 4U, MemSize::Float);
	TestCodeNoteSize(L"[float32] Test", 4U, MemSize::Float);
	TestCodeNoteSize(L"Test float", 4U, MemSize::Float);
	TestCodeNoteSize(L"Test floa", 1U, MemSize::Unknown);
	TestCodeNoteSize(L"is floating", 1U, MemSize::Unknown);
	TestCodeNoteSize(L"has floated", 1U, MemSize::Unknown);
	TestCodeNoteSize(L"16-afloat", 1U, MemSize::Unknown);

"[8bit] Fish Up the Cat floater" being treated as a floating point

That does not happen. "[8bit] Fish Up the Cat float" could be affected. Maybe something could be done to ignore extraneous "float" words if an explicit non-adjacent size exists in the string.

Require some sort of bracketing: parentheses, square brackets to surround it. Ex: (float) [float]

That would be inconsistent with non-float notations. There are many notes like "16-bit money value" already in the system. Making brackets required would break those.

[redwizard42]

That does not happen. "[8bit] Fish Up the Cat float" could be affected. Maybe something could be done to ignore extraneous "float" words if an explicit non-adjacent size exists in the string.

That's probably worth doing. I think I was thinking of old behavior, thanks to a conversation about something, but preferring other noted sizes sounds worthwhile.