Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Conflicting PSR-4 Autoload Paths in moduleinfo.json #144

Closed
RobinTheHood opened this issue Nov 9, 2023 · 0 comments · Fixed by #156
Closed

Handle Conflicting PSR-4 Autoload Paths in moduleinfo.json #144

RobinTheHood opened this issue Nov 9, 2023 · 0 comments · Fixed by #156
Labels
bug Something isn't working enhancement New feature or request
Milestone
v1.23.0

Comments

@RobinTheHood
Copy link
Owner

Currently, module manufacturers have the ability to define their own PSR-4 autoloads in the moduleinfo.json. However, there is a potential issue when different directories are specified for the same namespace. In such cases, MMLC should either throw an error or provide a warning during installation.

Error A:

"ModifiedCommunityModules\\": "/vendor-no-composer/modifiedcommunitymodules"
"RobinTheHood\\": "/vendor-no-composer/modifiedcommunitymodules"

Error B:

"RobinTheHood\\": "/vendor-no-composer/modifiedcommunitymodules"
"RobinTheHood\\": "/vendor-no-composer/robinthehood"
@RobinTheHood RobinTheHood added bug Something isn't working enhancement New feature or request labels Nov 9, 2023
@RobinTheHood RobinTheHood added this to the v1.22.0 milestone Nov 9, 2023
@RobinTheHood RobinTheHood modified the milestones: v1.22.0, Backlog Nov 28, 2023
@RobinTheHood RobinTheHood modified the milestones: Backlog, v1.23.0 Dec 5, 2023
@RobinTheHood RobinTheHood linked a pull request Dec 30, 2023 that will close this issue
feat: display an error if autoload entries conflict. #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
MMLC Project
Status: Done
Milestone
v1.23.0
Development

Successfully merging a pull request may close this issue.

feat: display an error if autoload entries conflict. RobinTheHood/ModifiedModuleLoaderClient
1 participant
@RobinTheHood