Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #90: team-05 - Saving pictures #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GustavoSaturnino
Copy link

Now images can be saved!
Pay attention to "saveImagesPdf" and "saveImagesPng", if == "true", images be saved on actual directory, if == a string that be a way to a specific directory, you can save in.

@Gui-FernandesBR Gui-FernandesBR changed the title issue-#90-team-05 Issue #90: - team-05 - Saving pictures Aug 28, 2022
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 28, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR requested review from luimot and removed request for giovaniceotto August 28, 2022 21:10
@Gui-FernandesBR Gui-FernandesBR changed the title Issue #90: - team-05 - Saving pictures Issue #90: team-05 - Saving pictures Aug 28, 2022
@FranzYuri FranzYuri requested review from FranzYuri and removed request for FranzYuri August 28, 2022 23:21
@luimot
Copy link

luimot commented Aug 29, 2022

Hi @GustavoSaturnino thank you for submitting your challenge!
I'm having some trouble reproducing this issue on my machine, would like your insight about it, did try this on python versions 3.10.6 and 3.8.0:
I can save the images on the path I specify, as you've informed on your PR, but the images seem to be blank

image

Where output.png is the one exported directly via VSCode, the Jupyter Notebooks I used to test are the following:

image

image

These are the Jupyter Notebooks for Environment and EnvironmentAnalysis respectively. Can you help me to see if there's something I did wrong? Thank you in advance and keep the good work

@luimot
Copy link

luimot commented Sep 2, 2022

Hi again @GustavoSaturnino . So, I've reviewed it and as we discussed privately, the "Flight Trajectory" was being shown, but there's a problem with the code organization, basically when using plt.savefig() after plt.show(), the plot is erased and therefore we observe the blank image, one example of what can be done to fix this is shown below:
image
I've seen that you understood the problem and solved it and therefore I can understand it as a done task, thanks again for your participation on the Hackathon, keep the good work and I hope that you can contribute to RocketPy in the future!

@luimot luimot added 10 points Easy challenges! 25 points Medium challenges! and removed 10 points Easy challenges! labels Sep 2, 2022
@Gui-FernandesBR
Copy link
Member

May recieve an extra 20% points since it was the onlly team solving this challege

@Gui-FernandesBR Gui-FernandesBR added the extra_points Exceptionally ingenious solutions label Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
25 points Medium challenges! extra_points Exceptionally ingenious solutions team-05
Projects
Development

Successfully merging this pull request may close these issues.

Saving pictures
4 participants