Skip to content
This repository has been archived by the owner on Aug 18, 2019. It is now read-only.

Assemble/find a list of test vectors #7

Open
est31 opened this issue Aug 14, 2018 · 11 comments
Open

Assemble/find a list of test vectors #7

est31 opened this issue Aug 14, 2018 · 11 comments
Assignees

Comments

@est31
Copy link
Member

est31 commented Aug 14, 2018

We need some mp3 files to test the code on. They need to be licensed appropriately, e.g. public domain. They should reflect a variety of encoders as well as encoder parameters, modes, etc.

This is a good starting point, but I don't know which format the .bit files are in: https://github.com/lieff/minimp3/tree/master/vectors

@lovesegfault lovesegfault mentioned this issue Aug 14, 2018
12 tasks
@mainrs
Copy link

mainrs commented Aug 15, 2018

Mixed data. Some are layers, some are valid mp3 files. Others only contain the header.

@lieff
Copy link

lieff commented Aug 15, 2018

Good point. I've added self-generated vectors which I use for performance testing https://github.com/lieff/minimp3/tree/master/vectors/performance . This is public domain.
As for others, most of them from testing procedure supplied with ISO standard and reference code. Unfortunately my old archive do not contain any license file. ffmpeg fate uses same standard vectors http://fate-suite.ffmpeg.org/mp3-conformance/ and no license information too. I want find someone who clarify what license for standard reference vectors. But currently I just store them same way as ffmpeg fate.

Others based on standard vectors. I'm not sure about ILL_* origin (this is specially-broken vectors for stability\error correction testing), I need time to investigate.

@lieff
Copy link

lieff commented Aug 15, 2018

About .bit files format:
ILL* - mixed layer 1\2\3
l1_* - MPEG layer 1
l2_* - MPEG layer 2
l3_* - MPEG layer 3
M2L3_* MPEG layer 3
MPEG versions also mixed.

@mainrs
Copy link

mainrs commented Aug 15, 2018

@lieff how did you find that out? I tried running file on them but it returned garbage for me. :)

@lieff
Copy link

lieff commented Aug 15, 2018

@sirwindfield For ILL* and *nonstandard* it's normal, they broken to trigger bugs in decoder. Others should be decoded\played normally.
ffplay can play them, (but showed layer 1 and layer 2 as mp3 too).

@mainrs
Copy link

mainrs commented Aug 15, 2018

I was wondering, the RustAudio group, is it also "responsible" for metadata? What about merging existing projects into the organization, like rust-id3 and rust-metaflac?

@est31
Copy link
Member Author

est31 commented Aug 16, 2018

@sirwindfield existing projects of these kinds are definitely welcome!

@lieff
Copy link

lieff commented Aug 16, 2018

ILL* vectors is from Philips MPEG Audio Test Suite http://www.mpegmultichannel.free.fr/Mpeg.pdf

@lieff
Copy link

lieff commented Aug 17, 2018

Here also https://samples.ffmpeg.org/A-codecs/MP3/ no mention of license too.

@mainrs
Copy link

mainrs commented Aug 17, 2018

@lieff I found this some directories up in the tree: https://samples.ffmpeg.org/HEADER.txt.

@lieff
Copy link

lieff commented Aug 17, 2018

So, licence should be clarified at webmaster(AT)ffmpeg(DOT)org.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants