feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2708] avatar stack support #788
+1,067
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoyu0722
commented
Sep 3, 2024
xiaoyu0722
commented
| grouped | horizontal |
|---|---|
xiaoyu0722
requested review from
billzhou0223
and removed request for
a team
xiaoyu0722
force-pushed
the
feat-avatar-stack-enhancement
branch
2 times, most recently
from
1066003
to
1f58254
Compare
billzhou0223
requested changes
Sep 4, 2024
Apps/Examples/Examples/FioriSwiftUICore/AvatarStack/AvatarStackExample.swift
Outdated
Show resolved
Hide resolved
xiaoyu0722
force-pushed
the
feat-avatar-stack-enhancement
branch
from
1f58254
to
b854caa
Compare
xiaoyu0722
force-pushed
the
feat-avatar-stack-enhancement
branch
from
b854caa
to
517c44e
Compare
xiaoyu0722
force-pushed
the
feat-avatar-stack-enhancement
branch
from
517c44e
to
6c7376d
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| /// :nodoc: | ||
| var body: some View { | ||
| if self.count == 0 { |
There was a problem hiding this comment.
Empty Count Violation: Prefer checking isEmpty over comparing count to zero. (empty_count)
billzhou0223
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.