From 904b90cb66831ed657b7ffdc577da04ff3fa51a5 Mon Sep 17 00:00:00 2001 From: Philipp Pracht Date: Tue, 23 Jul 2024 13:05:05 +0200 Subject: [PATCH] Bump fd styles, remove workaround (#3706) * bump fd styles, remove workaround * Update fundamental-styles to 0.37.0 * Remove `^` --------- Co-authored-by: Anna Milewska Co-authored-by: Anna Milewska <94687949+amilewskaa@users.noreply.github.com> Co-authored-by: Johannes Doberer Co-authored-by: Waldemar Mazurek --- core/package-lock.json | 46 ++++++++++++++++----------------- core/package.json | 2 +- core/src/styles/fd_horizon.scss | 5 ---- 3 files changed, 24 insertions(+), 29 deletions(-) diff --git a/core/package-lock.json b/core/package-lock.json index f9699f5a47..6c9f34647e 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -11,7 +11,7 @@ "@sveltejs/vite-plugin-svelte": "^2.5.3", "chai": "^4.3.6", "css-tree": "^2.3.1", - "fundamental-styles": "0.33.2", + "fundamental-styles": "0.37.0", "jest": "^28.1.3", "jest-environment-jsdom": "^28.1.3", "jsdom": "^20.0.0", @@ -2835,20 +2835,20 @@ } }, "node_modules/@sap-theming/theming-base-content": { - "version": "11.10.0", - "resolved": "https://registry.npmjs.org/@sap-theming/theming-base-content/-/theming-base-content-11.10.0.tgz", - "integrity": "sha512-MPGq5pivR+MLzchyZTXwu+VM6ZAekaPxiMnEHYHTG3uorTpBzaW+JhP8mqV+yGD3mpIUuomjbBeWbedTHnB2nw==", + "version": "11.16.1", + "resolved": "https://registry.npmjs.org/@sap-theming/theming-base-content/-/theming-base-content-11.16.1.tgz", + "integrity": "sha512-722ycND1eY79IgfE+GAoV2Gu6ZdF5BHLJwrSliaQ9RJ5JtEK/oNkWTHIynRKOSfQLRVDvRBW5i8dvJCuwgYqew==", "dev": true, "peer": true }, "node_modules/@sap-ui/common-css": { - "version": "0.33.2", - "resolved": "https://registry.npmjs.org/@sap-ui/common-css/-/common-css-0.33.2.tgz", - "integrity": "sha512-0Gxf/6VXOyXljM4lumQzFxASePfA0WiicUZgGDeZV/dhDfsaxodc9gPZ6ACAMgcpMXBWDzORdOmZTzhBqB66kQ==", + "version": "0.37.0", + "resolved": "https://registry.npmjs.org/@sap-ui/common-css/-/common-css-0.37.0.tgz", + "integrity": "sha512-xZBDPfETVBNsLYgurrPqhqLZLlELKMg9wLU6wJeqsgvSjjYUiIJt8jTNnIR9qPY4Hc2cvjwBxlampLReoZDbAQ==", "dev": true, "peer": true, "dependencies": { - "@sap-theming/theming-base-content": "^11.10.0" + "@sap-theming/theming-base-content": "^11.15.0" } }, "node_modules/@sinclair/typebox": { @@ -5196,13 +5196,13 @@ } }, "node_modules/fundamental-styles": { - "version": "0.33.2", - "resolved": "https://registry.npmjs.org/fundamental-styles/-/fundamental-styles-0.33.2.tgz", - "integrity": "sha512-yvI8eIqLtCzF6a8u8rLB0MfSX8yXBd1SSMaihfyEBv1B/YNwAREBrW25anLq/xSFX4uQ3tLeiCH5YZdcgfjnqg==", + "version": "0.37.0", + "resolved": "https://registry.npmjs.org/fundamental-styles/-/fundamental-styles-0.37.0.tgz", + "integrity": "sha512-SIVlzqmkAnIFveUwsRmkISWeN5+YthbtKOdSplPjY++WdSvalpa0YD4u8ciNnPucwMxcrCG8QsOqcFNgzwctIg==", "dev": true, "peerDependencies": { - "@sap-theming/theming-base-content": "^11.10.0", - "@sap-ui/common-css": "0.33.2" + "@sap-theming/theming-base-content": "^11.15.0", + "@sap-ui/common-css": "0.37.0" } }, "node_modules/gensync": { @@ -13686,20 +13686,20 @@ } }, "@sap-theming/theming-base-content": { - "version": "11.10.0", - "resolved": "https://registry.npmjs.org/@sap-theming/theming-base-content/-/theming-base-content-11.10.0.tgz", - "integrity": "sha512-MPGq5pivR+MLzchyZTXwu+VM6ZAekaPxiMnEHYHTG3uorTpBzaW+JhP8mqV+yGD3mpIUuomjbBeWbedTHnB2nw==", + "version": "11.16.1", + "resolved": "https://registry.npmjs.org/@sap-theming/theming-base-content/-/theming-base-content-11.16.1.tgz", + "integrity": "sha512-722ycND1eY79IgfE+GAoV2Gu6ZdF5BHLJwrSliaQ9RJ5JtEK/oNkWTHIynRKOSfQLRVDvRBW5i8dvJCuwgYqew==", "dev": true, "peer": true }, "@sap-ui/common-css": { - "version": "0.33.2", - "resolved": "https://registry.npmjs.org/@sap-ui/common-css/-/common-css-0.33.2.tgz", - "integrity": "sha512-0Gxf/6VXOyXljM4lumQzFxASePfA0WiicUZgGDeZV/dhDfsaxodc9gPZ6ACAMgcpMXBWDzORdOmZTzhBqB66kQ==", + "version": "0.37.0", + "resolved": "https://registry.npmjs.org/@sap-ui/common-css/-/common-css-0.37.0.tgz", + "integrity": "sha512-xZBDPfETVBNsLYgurrPqhqLZLlELKMg9wLU6wJeqsgvSjjYUiIJt8jTNnIR9qPY4Hc2cvjwBxlampLReoZDbAQ==", "dev": true, "peer": true, "requires": { - "@sap-theming/theming-base-content": "^11.10.0" + "@sap-theming/theming-base-content": "^11.15.0" } }, "@sinclair/typebox": { @@ -15538,9 +15538,9 @@ "dev": true }, "fundamental-styles": { - "version": "0.33.2", - "resolved": "https://registry.npmjs.org/fundamental-styles/-/fundamental-styles-0.33.2.tgz", - "integrity": "sha512-yvI8eIqLtCzF6a8u8rLB0MfSX8yXBd1SSMaihfyEBv1B/YNwAREBrW25anLq/xSFX4uQ3tLeiCH5YZdcgfjnqg==", + "version": "0.37.0", + "resolved": "https://registry.npmjs.org/fundamental-styles/-/fundamental-styles-0.37.0.tgz", + "integrity": "sha512-SIVlzqmkAnIFveUwsRmkISWeN5+YthbtKOdSplPjY++WdSvalpa0YD4u8ciNnPucwMxcrCG8QsOqcFNgzwctIg==", "dev": true, "requires": {} }, diff --git a/core/package.json b/core/package.json index e72ace90f6..5d00d19002 100644 --- a/core/package.json +++ b/core/package.json @@ -8,7 +8,7 @@ "@sveltejs/vite-plugin-svelte": "^2.5.3", "chai": "^4.3.6", "css-tree": "^2.3.1", - "fundamental-styles": "0.33.2", + "fundamental-styles": "0.37.0", "jest": "^28.1.3", "jest-environment-jsdom": "^28.1.3", "jsdom": "^20.0.0", diff --git a/core/src/styles/fd_horizon.scss b/core/src/styles/fd_horizon.scss index 9a9382e974..79054f95a3 100644 --- a/core/src/styles/fd_horizon.scss +++ b/core/src/styles/fd_horizon.scss @@ -9,11 +9,6 @@ --luigi__shellbar--height: 3.5rem; } -.fd-shellbar .fd-shellbar__group .fd-shellbar__button:hover, -.fd-shellbar .fd-shellbar__group .fd-shellbar__button.is-hover { - box-shadow: var(--sapContent_Interaction_Shadow); -} - @font-face { font-family: 'SAP-icons'; src: url('@sap-theming/theming-base-content/content/Base/baseLib/sap_horizon/fonts/SAP-icons.woff') format('woff');