From 6094a2eec52a6f4391a657fbfc519f926bd4ce21 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Wed, 18 Aug 2010 12:57:43 -0400 Subject: [PATCH] Treat a zero-length password as a failure Some LDAP servers allow binding with blank passwords. We should not allow a blank password to authenticate the SSSD. --- server/providers/ldap/ldap_auth.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/server/providers/ldap/ldap_auth.c b/server/providers/ldap/ldap_auth.c index 28b3240b39b..5df4dbb4355 100644 --- a/server/providers/ldap/ldap_auth.c +++ b/server/providers/ldap/ldap_auth.c @@ -458,6 +458,13 @@ static struct tevent_req *auth_send(TALLOC_CTX *memctx, req = tevent_req_create(memctx, &state, struct auth_state); if (!req) return NULL; + /* Treat a zero-length password as a failure */ + if (password.length == 0) { + state->result = SDAP_AUTH_FAILED; + tevent_req_done(req); + return tevent_req_post(req, ev); + } + state->ev = ev; state->ctx = ctx; state->username = username;