From 687615d8357b20c386e2c8ff9ba2e89aa4a0f81f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20V=C3=A1vra?= <jvavra@redhat.com>
Date: Mon, 15 Jul 2024 13:05:01 +0200
Subject: [PATCH] tests: Add feature presence test suite

We need to check that features are present where expected.
---
 src/tests/system/tests/test_features.py | 139 ++++++++++++++++++++++++
 1 file changed, 139 insertions(+)
 create mode 100644 src/tests/system/tests/test_features.py

diff --git a/src/tests/system/tests/test_features.py b/src/tests/system/tests/test_features.py
new file mode 100644
index 00000000000..a58c436cd00
--- /dev/null
+++ b/src/tests/system/tests/test_features.py
@@ -0,0 +1,139 @@
+"""
+SSSD Feature presence suite
+
+:requirement: features
+"""
+
+from __future__ import annotations
+
+import pytest
+from sssd_test_framework.roles.client import Client
+from sssd_test_framework.topology import KnownTopology
+
+
+def get_sssd_version(client: Client):
+    """
+    Pull sssd version from client
+
+    :return: Tuple of major, minor, patch, release of the version
+    :rtype: tuple
+    """
+    major, minor, patch, release = client.host.get_package_version(package="sssd", raise_on_error=False)
+    return major, minor, patch, release
+
+
+@pytest.mark.importance("high")
+@pytest.mark.topology(KnownTopology.Client)
+def test_feature__sss_ssh_knownhosts(client: Client):
+    """
+    :title: Feature sss_ssh_knownhosts presence
+    :setup:
+        1. Make sure sssd is installed
+    :steps:
+        1. Check sss_ssh_knownhosts feature presence
+    :expectedresults:
+        1. The feature is present in sssd 2.10 and higher
+    :customerscenario: False
+    :requirement: Support 'KnownHostsCommand' and deprecate 'sss_ssh_knownhostsproxy'
+    """
+    major, minor, _, _ = get_sssd_version(client)
+    if (major == 2 and minor >= 10) or major > 2:
+        assert client.features["knownhosts"]
+    else:
+        assert not client.features["knownhosts"]
+
+
+@pytest.mark.importance("high")
+@pytest.mark.topology(KnownTopology.Client)
+def test_feature__files_provider(client: Client):
+    """
+    :title: Feature files-provider presence
+    :setup:
+        1. Make sure sssd is installed
+    :steps:
+        1. Check files-provider feature presence
+    :expectedresults:
+        1. The feature should not be present in sssd 2.10 and higher
+    :customerscenario: False
+    """
+    major, minor, _, _ = get_sssd_version(client)
+    if (major == 2 and minor >= 10) or major > 2:
+        assert not client.features["files-provider"]
+    else:
+        assert client.features["files-provider"]
+
+
+@pytest.mark.importance("high")
+@pytest.mark.topology(KnownTopology.Client)
+def test_feature__passkey(client: Client):
+    """
+    :title: Feature passkey presence
+    :setup:
+        1. Make sure sssd is installed
+    :steps:
+        1. Check passkey feature presence
+    :expectedresults:
+        1. The feature should be on RHEL 9.4+, CentOS 9+, Fedora 39+ and Ubuntu 23.10+
+    :customerscenario: False
+    :requirement: passkey
+    """
+    expect_passkey = False
+    if "Fedora" in client.host.distro_name:
+        expect_passkey = client.host.distro_major >= 39
+    elif "Red Hat Enterprise Linux" in client.host.distro_name:
+        expect_passkey = bool(
+            (client.host.distro_major == 9 and client.host.distro_minor >= 4) or client.host.distro_major > 9
+        )
+    elif "CentOS Stream" in client.host.distro_name:
+        expect_passkey = client.host.distro_major >= 9
+    elif "Ubuntu" in client.host.distro_name:
+        expect_passkey = not (
+            client.host.distro_major <= 23 or (client.host.distro_major == 23 and client.host.distro_minor < 10)
+        )
+    else:
+        pytest.skip("Unknown distro, no expectations set for passkey feature presence")
+
+    assert bool(client.features["passkey"] == expect_passkey), (
+        f"Passkey does not match expectations on"
+        f" {client.host.distro_name} {client.host.distro_major} {client.host.distro_minor}."
+    )
+
+
+@pytest.mark.importance("high")
+@pytest.mark.topology(KnownTopology.Client)
+def test_feature__ldap_use_ppolicy(client: Client):
+    """
+    :title: Feature ldap_use_ppolicy presence
+    :setup:
+        1. Make sure sssd is installed
+    :steps:
+        1. Check ldap_use_ppolicy feature presence
+    :expectedresults:
+        1. The feature should be present in sssd 2.10 and higher
+    :customerscenario: False
+    """
+    major, minor, _, _ = get_sssd_version(client)
+    if (major == 2 and minor >= 10) or major > 2:
+        assert client.features["ldap_use_ppolicy"]
+    else:
+        assert not client.features["ldap_use_ppolicy"]
+
+
+@pytest.mark.importance("high")
+@pytest.mark.topology(KnownTopology.Client)
+def test_feature__non_privileged(client: Client):
+    """
+    :title: Feature non-privileged presence
+    :setup:
+        1. Make sure sssd is installed
+    :steps:
+        1. Check non-privileged feature presence
+    :expectedresults:
+        1. The feature should be present in sssd 2.10 and higher
+    :customerscenario: False
+    """
+    major, minor, _, _ = get_sssd_version(client)
+    if (major == 2 and minor >= 10) or major > 2:
+        assert client.features["non-privileged"]
+    else:
+        assert not client.features["non-privileged"]