Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation note #1

Open
hmoffatt opened this issue Oct 9, 2020 · 0 comments
Open

documentation note #1

hmoffatt opened this issue Oct 9, 2020 · 0 comments

Comments

@hmoffatt
Copy link

hmoffatt commented Oct 9, 2020

The README says 'Lambda@Edge for serving Brotli or Gzipped file according to the Content-Encoding header" but it should be the Accept-Encoding header.

It should also be noted that Content-Encoding must be added to the metadata on the .gzip and .br files in the S3 bucket, or added in an origin-response Lambda@Edge event. I also found that awscli did not set the Content-Type on uploaded .br files automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hmoffatt