Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions zoomChanged action is not being called #896

Closed
Moath-Zaghdad opened this issue Mar 29, 2023 · 5 comments
Closed

extensions zoomChanged action is not being called #896

Moath-Zaghdad opened this issue Mar 29, 2023 · 5 comments
Labels
bug

Comments

@Moath-Zaghdad
Copy link
Contributor

Moath-Zaghdad commented Mar 29, 2023 •
edited
Loading

The grid is not showing the correct grid scale on Zoom change
I tried tracking the issue, and I've noticed that the extension's zoomChange method is not being called.

To Reproduce

  1. Open SVG-Edit V7.3.0 (or master)
  2. Change the zoom to 50%
  3. Click on the Show/Hide Grid button
  4. Change the zoom to 1000%
  5. Click on the Show/Hide Grid button twice to see what should have happened automatically on zoom change

SVG-Edit environment

  • Version: 7.2.0

Desktop:

  • OS: iOS
  • Browser: Firefox Developer Edition
  • Version: 112.0b7 (64-bit)
@jfhenon
Copy link
Collaborator

jfhenon commented Mar 30, 2023

I'm not able to reproduce the issue. Here is the video of the test I did following your instructions:

Screen.Recording.2023-03-30.at.23.44.07.mov

@Moath-Zaghdad
Copy link
Contributor Author

Sorry, the reproduce steps were missing one thing, start with a zoom of 50%

2023-03-31.mp4

@Moath-Zaghdad
Copy link
Contributor Author

@jfhenon This issue persists in the 7.3.3 release.
If you could provide me with some details on where to look in the code that would be amazing because I'd like to assist in resolving it.
Thank you.

@jfhenon
Copy link
Collaborator

jfhenon commented Dec 11, 2023

I could reproduce. I'm not yet sure where to look for but the changeZoom function is in BottomPanel.js

Moath-Zaghdad added a commit to Moath-Zaghdad/svgedit that referenced this issue Dec 29, 2023
@Moath-Zaghdad
fix: Call zoomChanged after updating the zoom (SVG-Edit#896)
a9b2987
Moath-Zaghdad added a commit to Moath-Zaghdad/svgedit that referenced this issue Dec 29, 2023
@Moath-Zaghdad
fix: Call zoomChanged event after updating the zoom (SVG-Edit#896)
a465c67
Moath-Zaghdad added a commit to Moath-Zaghdad/svgedit that referenced this issue Dec 29, 2023
@Moath-Zaghdad
fix: Call zoomChanged event after updating the zoom (SVG-Edit#896)
4bcd0fe 
The zoomChange method was not being called on the extensions, and this
commit fixes this by calling the runExtensions method after updating the
zoom.
This commit addresses issue SVG-Edit#986.
Moath-Zaghdad added a commit to Moath-Zaghdad/svgedit that referenced this issue Dec 29, 2023
@Moath-Zaghdad
fix: Call zoomChanged event after updating the zoom
ee03fad 
The zoomChange method was not being called on the extensions, and this
commit fixes this by calling the runExtensions method after updating the
zoom.
This commit addresses issue SVG-Edit#896
Moath-Zaghdad added a commit to Moath-Zaghdad/svgedit that referenced this issue Dec 29, 2023
@Moath-Zaghdad
fix: Call zoomChanged event after updating the zoom
efe7c12 
The zoomChange method was not being called on the extensions, and this
commit fixes this by calling the runExtensions method after updating the
zoom.
This commit addresses issue SVG-Edit#896
@Moath-Zaghdad Moath-Zaghdad mentioned this issue Dec 29, 2023
Merged
@Moath-Zaghdad
Copy link
Contributor Author

I have created this PR #940 to fix this issue

jfhenon pushed a commit that referenced this issue Jan 14, 2024
@Moath-Zaghdad
fix: Call zoomChanged event after updating the zoom (#940)
24f78d3 
The zoomChange method was not being called on the extensions, and this
commit fixes this by calling the runExtensions method after updating the
zoom.
This commit addresses issue #896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moath-Zaghdad @jfhenon