Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Using assertContains() with string haystacks is deprecated #90

Open
gesinn-it-gea opened this issue Apr 5, 2022 · 2 comments
Open

Tests: Using assertContains() with string haystacks is deprecated #90

gesinn-it-gea opened this issue Apr 5, 2022 · 2 comments
Labels
code quality

Comments

@gesinn-it-gea
Copy link
Member

Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

See CI output for examples.
@malberts
Copy link

malberts commented Apr 5, 2022

There's a trait you can add. I did this for SRF:
SemanticMediaWiki/SemanticResultFormats@054e482

@gesinn-it-gea
Copy link
Member Author

@malberts thanks for the hint! This issue was more meant as a heads-up for future work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malberts @gesinn-it-gea