-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mermaid to 10.2.1 and fix mermaid.init() call #96
Update Mermaid to 10.2.1 and fix mermaid.init() call #96
Conversation
* Inserted random function instead of relying on Date().getTime() * removed unused config reading
for reference: mermaid-js RELEASE NOTES for 9.0.0 https://github.com/mermaid-js/mermaid/releases/tag/9.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to 10.2.1
Hello, I tested your branch against mediawiki 1.35 ; and ... with 10.2.1 (also with others 10.x) firefox chokes on "SyntaxError: function statement requires a name" ; couldn't spot the exact problem on minified javascript, but the 10.x.x versions all seems to have the same symptoms. (and btw Chrome also shows the same error). When editing your package.json to go back to mermaid 9.4.3 it runs fine. Is there a requirement somewhere on yarn version (1.22.5) or other system tool maybe ? |
@antibarbie the problem you're getting is probably from how the mediawiki resourceloader minifies everything, including already-minified vendored packages like this one. There is an install script that adds a |
TBH right now I don't understand, if I could or should do anything else. Is there something needed from my side? |
Ah, already surpassed: #102 |
This PR addresses or contains:
This PR includes:
Overtakes #94