Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more SourceProcessor like replace #13

Closed
lumixraku opened this issue Oct 6, 2023 · 3 comments · Fixed by #24
Closed

Add more SourceProcessor like replace #13

lumixraku opened this issue Oct 6, 2023 · 3 comments · Fixed by #24
Assignees
@ShellWen
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lumixraku
Copy link

Is it possible add more SourceProcessor? Now only insert before and after.
could add a processor just replace the whole file?
@ShellWen ShellWen self-assigned this Oct 6, 2023
@ShellWen ShellWen added the enhancement New feature or request label Oct 6, 2023
@ShellWen
Copy link
Owner

ShellWen commented Oct 6, 2023

Yes, but I currently don't have lots of time focused on this. However, I will get it done.

@ShellWen
Copy link
Owner

ShellWen commented Oct 6, 2023

We plan to implement two replacement methods: one based on regular expressions and the other based on text. Is this okay? @lumixraku

@lumixraku
Copy link
Author

It's cool with me

@ShellWen ShellWen added the good first issue Good for newcomers label Nov 28, 2023
@ShellWen ShellWen changed the title Is it possible add more SourceProcessor? Like replace? Add more SourceProcessor like replace Nov 28, 2023
ShellWen added a commit that referenced this issue Nov 28, 2023
@ShellWen
✨ Add more processors types
6edd3d4 
- Add `replace` to replace string in source directly
- Add `replace-regexp` to replace string in source by regexp

See also: #13
ShellWen added a commit that referenced this issue Nov 28, 2023
@ShellWen
✨ Add a new matcher type resource-name-regexp
46d451f 
See also: #13
@ShellWen ShellWen linked a pull request Nov 28, 2023 that will close this issue
add more sourceprocessor #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShellWen ShellWen

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add more sourceprocessor ShellWen/v8_killer
2 participants
@lumixraku @ShellWen