[Bug Fix] predeploy_sequence is wrong when there are conflicts between built-ins and CRDs #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
force-pushed
the
fix-calico
branch
2 times, most recently
from
0a46d4b
to
b71565a
Compare
1 task
dturn
commented
Feb 2, 2021
| @@ -3,7 +3,7 @@ | |||
| module Krane | |||
| class DaemonSet < PodSetBase | |||
| TIMEOUT = 5.minutes | |||
| SYNC_DEPENDENCIES = %w(Pod) | |||
| SYNC_DEPENDENCIES = %w(Pod.apps) | |||
There was a problem hiding this comment.
Having to add a group here sucks. I'm need to look at the behavior for kubectl and see what group it picks if there are multiple for a kind 🤞 its not the one a crd defines...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
E.g. If a CRD defines a Kind that is also in our hard coded predeploy_sequence, but with a different group, only one will be pre-deployed. That's a bug.
Fix: #773
How is this accomplished?
The predeploy sequence now supports multiple groups per Kind.
This needs some tests too
What could go wrong?
This actually isn't the fix, it has a sublte bug where we'll always deploy something with that name ...
Or that this code is ugly and we really need an object instead of a hash...