don't associate a file with a different package that matches a prefix #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterm
force-pushed
the
fix-package-mismatch-on-overlapping-prefix
branch
from
f4d50ca
to
133619a
Compare
exterm
force-pushed
the
fix-package-mismatch-on-overlapping-prefix
branch
from
133619a
to
ca7ae0d
Compare
|
@gmcgibbon @shioyama can we get this straightforward bugfix merged? |
|
@rafaelfranca I see you've been active on this repo recently - can you give this small bugfix a review? |
gmcgibbon
approved these changes
May 7, 2024
|
Thanks, sorry for the delay! |
|
@gmcgibbon do you mind cutting a release with this included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix #297
What approach did you choose and why?
I think technically we shouldn't do string comparison for this, but the fix was so easy, and swapping in Pathname everywhere quite a bit of work, so I opted for this variant
What should reviewers focus on?
Type of Change
Additional Release Notes
This may reattribute files to other packages (the correct packages) and thus add or remove violations.
Checklist
Additional Notes
This work is sponsored by https://www.onemedical.com/