Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated flagging of rollback safety #879

Open
jarthorn opened this issue Mar 4, 2019 · 0 comments
Open

Automated flagging of rollback safety #879

jarthorn opened this issue Mar 4, 2019 · 0 comments

Comments

@jarthorn
Copy link

jarthorn commented Mar 4, 2019

Many pull request templates, including Shopify core, have a "This is safe to rollback" checkbox. This helps people during incidents to assess the risk of rolling back vs fixing forward. With our larger deploy batch sizes, and separate deploy batches for canary and production, it is becoming very hard for a human to assess rollback safety. This has resulted in situations where people have decided to fix forward rather than rollback, which adds significant time to the impact of a disruption. As one example, this came up during RCA discussion for https://github.com/Shopify/service-disruptions/issues/1037.

Idea: explicitly model "safe to rollback" in Shipit rather than via PR template checkbox. Perhaps it is exposed via HCTW as an extra field next to "Add to Merge queue". Shipit can than quickly determine if a batch of changes is "unsafe to rollback" and indicate this in the Shipit UI. This would not be foolproof but it would help a human responder more quickly discover cases where rollback is not safe.

This would also help us collect a list of cases that are not safe that we can work towards eliminating, with the goal of eventually never shipping changes that are not "safe to rollback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant