Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release documentation #369

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Update release documentation #369

merged 2 commits into from
Mar 10, 2022

Conversation

neufeldtech
Copy link
Contributor

Resolves #368

README.md Show resolved Hide resolved
@neufeldtech
Copy link
Contributor Author

Note: When testing these instructions, I came across a problem with the proposed workflow of creating a pull request for updating the release notes and preparing the release...

When I did this, because github forced me to do a squash and merge, then there was a mismatch between the commit that landed on master and the tag that I had previously created locally.

Options for this workflow are:

  • Prepare release and always push release commit directly to master, and push tag directly afterwards
    OR
  • Create the tag after the merge commit lands on master - however, then this also means that we can't really run the 'make test-release' workflow locally because then it would cause us the need to update our local tag again.

@miry when you're back from vacation, let's chat on this some more

RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@miry
Copy link
Contributor

miry commented Mar 8, 2022

@neufeldtech Thank you for the doc ❤️

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
@neufeldtech
Copy link
Contributor Author

Hmmm, I might have a flaky test....

=== RUN   TestProxyMetricsReceivedSentBytes
    metrics_test.go:36: expected: [toxiproxy_proxy_received_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5 toxiproxy_proxy_sent_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5] got: []

This test was added in my prometheus metrics PR #366

neufeldtech and others added 2 commits March 10, 2022 08:59
Co-authored-by: Michael Nikitochkin <michael.nikitochkin@shopify.com>
attempt to address race condition in tests that happens in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create RELEASE.md document
3 participants