Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline not behaving as expected #532

Open
mattydboom opened this issue Aug 9, 2024 · 2 comments
Open

Outline not behaving as expected #532

mattydboom opened this issue Aug 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mattydboom
Copy link

mattydboom commented Aug 9, 2024

I have found that the Outline trace function does not generate the desired path for some projects. See below example. The 'expected' path shown in Green, but the 'actual' generated outline path is something more like that shown in Red.

I suspect this an issue with the inner tool path island, but as this is not uncommon of a typical job & otherwise is just a simple rectangular shape, I would expect it to be dealt with correctly. I am also attaching the tool path code to aid with the problem finding.... Outline Issue.txt

Expected Outline Path:
image

Actual Outline Path:
image

@walidkayhan walidkayhan added the bug Something isn't working label Nov 5, 2024
@SienciLabs
Copy link
Contributor

@kglovern maybe we could introduce a new toggle in the settings to switch between a more simple and a more complex outline? Since I know where we run a simple box we didn't tend to have these issues, but since we switched to the more complex form outlining sequence there are sometimes exceptions that appear. I think people would appreciate the more complex one more, but if it's making odd movements like this then that'd give the simple one to fall back onto. Or maybe there's some other way we could introduce some type of error checking in the outline feature to avoid situations where it collapses in on itself like this

@mattydboom
Copy link
Author

mattydboom commented Nov 7, 2024

@SienciLabs @kglovern yes I think having the option would be a great idea.

I personally use the outline function to quickly get an idea of the extents of the project (to make sure its entirely sitting within the stock)..... so just having a bounding square / circular outlining path would be great for this, and a good deal faster than the complex figure hugging path also.

A bit like the below framing options available within Lightburn. Perhaps on the new UI the outline tool can have a drop down allowing you to change between the three modes (Complex, Square, Circular) and will always remember/stay on your last selected choice.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants