Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] managing the dependencies #94

Open
fkiraly opened this issue Sep 20, 2024 · 0 comments
Open

[MNT] managing the dependencies #94

fkiraly opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fkiraly
Copy link
Contributor

fkiraly commented Sep 20, 2024

Looking at pyproject, it is great how there are very few dependencies!

Though, I think it is not entirely perfect. For intsance, GFO implies sklearn, so sklearn always gets installed, not just when the integrations dep set is added.

I would suggest to move to a dependency isolation setup, where GFO also also gets isolated as a softdep, that way we can also avoid sklearn.

This would be easily possible with #93, if the skbase based design is adopted, and dependencies are tracked and isolated within the optimizers.

@fkiraly fkiraly added the enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant