Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Spawn a Firework #6762

Closed
1 task done
Dsa-123 opened this issue Jun 3, 2024 · 18 comments
Closed
1 task done

Can't Spawn a Firework #6762

Dsa-123 opened this issue Jun 3, 2024 · 18 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Dsa-123
Copy link

Dsa-123 commented Jun 3, 2024

Skript/Server Version

[18:53:08 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[18:53:08 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[18:53:08 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[18:53:08 INFO]: [Skript] Server Version: git-Paper-496 (MC: 1.20.4)
[18:53:08 INFO]: [Skript] Skript Version: 2.8.6 (skriptlang-github)
[18:53:08 INFO]: [Skript] Installed Skript Addons: None
[18:53:08 INFO]: [Skript] Installed dependencies:
[18:53:08 INFO]: [Skript]  - Vault v1.7.3-b131
[18:53:08 INFO]: [Skript]  - WorldGuard v7.0.7+216b061

Bug Description

Hello SkriptLang Team,
I've updated my Skript version from 2.7.4 to 2.8.6 recently and it seems that I can't spawn fireworks anymore

Expected Behavior

Expected to spawn a firework

Steps to Reproduce

After enabling Skript effect commands write !spawn firework at player in chat

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth
Copy link
Member

sovdeeth commented Jun 3, 2024

This is likely the same problem that #6760 fixes. Try that nightly, see if it fixes it.

@sovdeeth sovdeeth added the waiting for reply The report needs a response from the reporter to determine course of action. label Jun 3, 2024
@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

Sorry, I'm new to GitHub and I couldn't figure out how to try that pull request you mentioned

@sovdeeth
Copy link
Member

sovdeeth commented Jun 3, 2024

Sorry, I'm new to GitHub and I couldn't figure out how to try that pull request you mentioned

Click on the link to the PR, then click on the Checks tab, click on the Java 21 tab on the left, then download the skript-nightly under artifacts

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Jun 3, 2024
@sovdeeth
Copy link
Member

sovdeeth commented Jun 3, 2024

Yeah, looks like we'll have to either force firework particle or firework spark for the particle name. Pickle's aware and will update the PR to fix this too.

@sovdeeth sovdeeth added the PR available Issues which have a yet-to-be merged PR resolving it label Jun 3, 2024
@APickledWalrus
Copy link
Member

I've updated the PR again to remove the firework conflict. If you use the latest build it should work. Let us know if not.

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

Perfect. I deleted my comment by accident. Thank you so much

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

I've updated the PR again to remove the firework conflict. If you use the latest build it should work. Let us know if not.

I will test it in few moments

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

Not working

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

If you use the latest build it should work. Let us know if not.

Skript Version: 2.8.6-nightly-9326c82 (skriptlang-nightly) is that the latest build?

@APickledWalrus
Copy link
Member

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

OK I tried that and it still not letting me to spawn fireworks

@APickledWalrus
Copy link
Member

is it still printing an error?

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

It doesn't display any error

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

image

command test:
    trigger:

        broadcast "Started"
        loop 10 times:

            spawn a firework at player
            broadcast "%last spawned entity%"
            wait 5 ticks

        broadcast "The End"

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

Also this is what send when using getClass method
image

@Dsa-123
Copy link
Author

Dsa-123 commented Jun 3, 2024

I tried to do some debugging because I thought it would be parsing error but no result at all
image

@sovdeeth
Copy link
Member

sovdeeth commented Jun 3, 2024

Seems to be due to FIREWORK_ROCKET being marked as non-spawnable by Bukkit, while clearly being able to be spawned.

@APickledWalrus APickledWalrus removed PR available Issues which have a yet-to-be merged PR resolving it labels Jun 3, 2024
@APickledWalrus APickledWalrus self-assigned this Jun 3, 2024
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jun 3, 2024
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jun 6, 2024
@APickledWalrus
Copy link
Member

@Dsa-123 Are you able to test with the latest nightly build from #6764? It should resolve this issue.

@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

3 participants