Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: validate columns in tables config #124

Closed
bloep opened this issue Mar 21, 2024 · 3 comments
Closed

DX: validate columns in tables config #124

bloep opened this issue Mar 21, 2024 · 3 comments
Labels
feature New feature or request
Milestone

Comments

@bloep
Copy link

bloep commented Mar 21, 2024

Is your feature request related to a problem? Please describe.
I am writing a config for over 250 database tables, each with more than 10 columns.
After I have created the config and generated a test dump (which takes 15 minutes due to the size of the database), I check it.
Columns were not changed because I had typos in the names e.g. address vs address.

Describe the solution you'd like
Before it starts exporting the data, it would be good to validate the config once against the schema to see if all columns are really there.

@guvra guvra added the feature New feature or request label Mar 21, 2024
@guvra
Copy link
Collaborator

guvra commented Mar 21, 2024

Implemented in #125 but all existing templates in app/config/templates must be tested before merging.

@guvra guvra added this to the 5.0.0 milestone Mar 26, 2024
@guvra
Copy link
Collaborator

guvra commented Mar 26, 2024

FYI, it's a breaking change, so it will be included in the 5.0.0 release.

@bloep
Copy link
Author

bloep commented Mar 28, 2024

Thanks for implementing it. IMHO we can close the issue

@bloep bloep closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants