chore: refactor github ci so that it doesn't use 1.65 for tests #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
suggested changes
Feb 28, 2024
There was a problem hiding this comment.
Hm, maybe the config should be changed to be more like in e.g. https://github.com/rust-windowing/wayland-csd-frame/blob/main/.github/workflows/ci.yml ? It's like way easier to comprehend.
If you want to test correctly on msrv, you can use the cargo update -p PACKAGE --precise VERSION that's what we do in winit.
We also proposed solution like rust-windowing/winit#3085 (comment) which you may consider adopting, since lock file makes bisecting more pleasant.
elinorbgr
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could help fix CI issues on some PRs like #441 and #437