Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Use strong references to gbm_device in Surface/BufferObject #25

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Aug 17, 2023

Using a strong reference is the most obvious way to address Smithay/smithay#1102. And getting rid of DeviceDestroyedError makes the API a fair bit cleaner.

Though Device.fd will also need to be reference counted for this to fix the issue here. Presumably. And this will need testing. Leaving as a draft at the moment.

Any reason not to do this, or why it may cause problems? I guess Device will require T: Sync...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant