Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature name to use_bindgen #62

Closed
wants to merge 1 commit into from
Closed

Change feature name to use_bindgen #62

wants to merge 1 commit into from

Conversation

Vixea
Copy link
Contributor

@Vixea Vixea commented Oct 30, 2023

No description provided.

@Drakulix
Copy link
Member

But why, this just breaks the api. I might merge it, when a new version is inbound anyway.

@Vixea
Copy link
Contributor Author

Vixea commented Oct 31, 2023 •
edited
Loading

Yeah of course, as for why it is really only for aesthetics and unifying all the libraries in Smithay that use bindgen, I feel like use_bindgen is what the rest of the rust ecosystem uses. It's one less thing to keep in your head ¯\_(ツ)_/¯

@Vixea Vixea changed the title Change feature name to match drm-rs Change feature name to use_bindgen Oct 31, 2023
@Drakulix
Copy link
Member

Fixed on master

@Drakulix Drakulix closed this Jan 19, 2024
@Vixea Vixea deleted the sync-feature-name branch January 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vixea @Drakulix