Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Properties incorrectly appear as dates in entity panel #882

Open
5 tasks done
exploide opened this issue Sep 24, 2024 · 1 comment
Open
5 tasks done

Bug: Properties incorrectly appear as dates in entity panel #882

exploide opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working ticketed (automation only) Ticket has been created internally for tracking

Comments

@exploide
Copy link
Contributor

Description:

Since #782 BHCE shows additional AD properties for domain objects. But some of them are incorrectly decoded.

"Machine Account Quota" and "Password History Length" should probably not decode as datetimes and I'm also not sure if "Lockout Observation Window" makes sense.

See screenshot below.

Are you intending to fix this bug?

no

Component(s) Affected:

  • UI

Steps to Reproduce:

  1. Collect a domain with latest SharpHound
  2. Ingest data
  3. Open details pane of domain object
  4. See incorrectly decoded data

Expected Behavior:

Correctly decoded values, e.g. "Machine Account Quota" as a numeric value.

Actual Behavior:

Incorrectly decoded values, e.g. "Machine Account Quota" as a datetime value.

Screenshots/Code Snippets/Sample Files:

properties

Environment Information:

BloodHound: 5.15.1

Collector: SharpHound 2.5.7

OS: Fedora 40

Browser (if UI related): Firefox 130.0.1 (64-bit)

Contributor Checklist:

  • I have searched the issue tracker to ensure this bug hasn't been reported before or is not already being addressed.
  • I have provided clear steps to reproduce the issue.
  • I have included relevant environment information details.
  • I have attached necessary supporting documents.
  • I have checked that any JSON files I am attempting to upload to BloodHound are valid.
@exploide exploide added bug Something isn't working triage This issue requires triaging labels Sep 24, 2024
@StephenHinck StephenHinck added ticketed (automation only) Ticket has been created internally for tracking and removed triage This issue requires triaging labels Sep 24, 2024
@StephenHinck
Copy link
Collaborator

Hey @exploide - thanks for reporting. We're aware of the issue - it's purely a UI-side issue where Javascript is trying to interpret things aggressively as dates (just like Excel 🙃). We've got this on the backlog to fix the formatting for those values.

@StephenHinck StephenHinck changed the title Bug: Incorrect decoding of additional AD properties Bug: Properties incorrectly appear as dates in entity panel Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ticketed (automation only) Ticket has been created internally for tracking
Projects
None yet
Development

No branches or pull requests

2 participants